Repository navigation
Expose the saved death identity for character reconciliation - #44
Merged
Merged
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 12, 2026
Merged
ryanbarlow97
marked this pull request as ready for review
October 12, 2026 20:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Death events may be lost after a server crash, so consumers need the most recent saved death ID to reconcile cleanup without repeating it after revival. Add a compatible default
CharacterIdentity.deathId(UUID)and main-threadCharacters.deathId(UUID)facade. Existing providers return empty until they implement it.Validation:
tfmc-mvn -o -B --no-transfer-progress clean verifyon CachyOS: 204 tests pass, 100% line coverage, including no provider, old-provider default, forwarded ID, and off-thread refusal. RPCharacters provider implementation is part of #103; SimpleFactions #160 consumes the lookup. Intended provider version: TLibs 2.4.1, held with the stage 5 set.Companion documentation: TF-Minecraft/Docs#200.