Skip to content

Expose the saved death identity for character reconciliation - #44

Merged
ryanbarlow97 merged 1 commit into
mainfrom
feat/character-death-lookup
Oct 12, 2026
Merged

ryanbarlow97 merged 1 commit into
mainfrom
feat/character-death-lookup

Conversation

@ryanbarlow97

@ryanbarlow97 ryanbarlow97 commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Death events may be lost after a server crash, so consumers need the most recent saved death ID to reconcile cleanup without repeating it after revival. Add a compatible default CharacterIdentity.deathId(UUID) and main-thread Characters.deathId(UUID) facade. Existing providers return empty until they implement it.

Validation: tfmc-mvn -o -B --no-transfer-progress clean verify on CachyOS: 204 tests pass, 100% line coverage, including no provider, old-provider default, forwarded ID, and off-thread refusal. RPCharacters provider implementation is part of #103; SimpleFactions #160 consumes the lookup. Intended provider version: TLibs 2.4.1, held with the stage 5 set.

Companion documentation: TF-Minecraft/Docs#200.

@coderabbitai

coderabbitai Bot commented Oct 12, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the size:S 10-29 effective changed lines (tests excluded in mixed PRs). label Oct 12, 2026
@ryanbarlow97
ryanbarlow97 marked this pull request as ready for review October 12, 2026 20:36
@ryanbarlow97
ryanbarlow97 merged commit fe7f855 into main Oct 12, 2026
5 checks passed
@ryanbarlow97
ryanbarlow97 deleted the feat/character-death-lookup branch October 12, 2026 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 effective changed lines (tests excluded in mixed PRs).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant