Skip to content

Pin character faction APIs for stage 5 - #94

Merged
ryanbarlow97 merged 1 commit into
mainfrom
chore/character-api-pins
Oct 12, 2026
Merged

ryanbarlow97 merged 1 commit into
mainfrom
chore/character-api-pins

Conversation

@ryanbarlow97

Copy link
Copy Markdown
Contributor

Pin SimpleFactions 4.0.0 and TLibs 2.4.1 for the coordinated character migration. Battle participation activity retains its account UUID contract.

Validation: tfmc-mvn -o -B --no-transfer-progress clean verify passed 959 tests and all existing coverage checks. Provider artifacts were installed locally from the reviewed stage 5 branches; no releases are published before the full rehearsal.

Depends on TF-Minecraft/SimpleFactions#160 and TF-Minecraft/TLibs#44. Documentation: TF-Minecraft/Docs#200.

@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e7799045-6b69-4ade-8bdf-02902c5766df

📥 Commits

Reviewing files that changed from the base of the PR and between 3907543 and 4a56b02.


📒 Files selected for processing (1)
  • pom.xml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.



📝 Summary

Summary by CodeRabbit

  • Chores
    • Updated the SimpleFactions and TLibs library versions.

Walkthrough

The Maven version properties for SimpleFactions and TLibs were updated.

Changes

Dependency version updates

Layer / File(s) Summary
Update Maven dependency versions
pom.xml
The SimpleFactions version changed from 3.0.1 to 4.0.0. The TLibs version changed from 2.0.0 to 2.4.1.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: justinasla


Merge Risk: ⚪ Minimal · up to 4a56b

The dependency updates are provisioned for CI, and the inspected consumers match the pinned APIs. No actionable merge-blocking risk is established.

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the size:XS 0-9 effective changed lines (tests excluded in mixed PRs). label Oct 12, 2026
@ryanbarlow97
ryanbarlow97 marked this pull request as ready for review October 12, 2026 21:02
@ryanbarlow97
ryanbarlow97 merged commit 087fc83 into main Oct 12, 2026
4 of 5 checks passed
@ryanbarlow97
ryanbarlow97 deleted the chore/character-api-pins branch October 12, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 effective changed lines (tests excluded in mixed PRs).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant