Repository navigation
server: page the provider list APIs - #117
Merged
Merged
Conversation
littlegrasscao
marked this pull request as ready for review
October 9, 2026 17:04
littlegrasscao
force-pushed
the
server/split2/11a-provider-pagination
branch
from
October 13, 2026 23:46
8e19e1f to
57df5a5
Compare
littlegrasscao
force-pushed
the
server/split2/11a-provider-pagination
branch
from
October 13, 2026 23:55
57df5a5 to
af8b97b
Compare
littlegrasscao
force-pushed
the
server/split2/11a-provider-pagination
branch
from
October 14, 2026 00:06
af8b97b to
713c006
Compare
littlegrasscao
force-pushed
the
server/split2/11a-provider-pagination
branch
from
October 14, 2026 00:14
713c006 to
4e5e3ba
Compare
littlegrasscao
force-pushed
the
server/split2/11a-provider-pagination
branch
from
October 14, 2026 00:39
4e5e3ba to
e1f36ef
Compare
littlegrasscao
force-pushed
the
server/split2/11a-provider-pagination
branch
from
October 14, 2026 00:42
e1f36ef to
4020fb0
Compare
littlegrasscao
force-pushed
the
server/split2/11a-provider-pagination
branch
from
October 14, 2026 00:56
4020fb0 to
3b5a561
Compare
littlegrasscao
force-pushed
the
server/split2/11a-provider-pagination
branch
from
October 14, 2026 19:24
3b5a561 to
3099caa
Compare
littlegrasscao
force-pushed
the
server/split2/11a-provider-pagination
branch
from
October 15, 2026 16:46
3099caa to
3e2b8a7
Compare
littlegrasscao
force-pushed
the
server/split2/11a-provider-pagination
branch
from
October 15, 2026 18:13
3e2b8a7 to
5045449
Compare
littlegrasscao
force-pushed
the
server/split2/11a-provider-pagination
branch
from
October 15, 2026 18:29
5045449 to
b818c65
Compare
littlegrasscao
force-pushed
the
server/split2/11a-provider-pagination
branch
from
October 15, 2026 23:34
b818c65 to
f5f4246
Compare
littlegrasscao
force-pushed
the
server/split2/11a-provider-pagination
branch
from
October 15, 2026 23:38
f5f4246 to
744ce0d
Compare
littlegrasscao
force-pushed
the
server/split2/11a-provider-pagination
branch
from
October 16, 2026 00:41
744ce0d to
d74e9e3
Compare
littlegrasscao
force-pushed
the
server/split2/11a-provider-pagination
branch
from
October 19, 2026 17:12
d74e9e3 to
fc59840
Compare
zhu-tom
added this pull request to stack #116
October 19, 2026 19:06
zhu-tom
approved these changes
Oct 19, 2026
zhu-tom
reviewed
Oct 19, 2026
littlegrasscao
force-pushed
the
server/split2/11a-provider-pagination
branch
3 times, most recently
from
October 19, 2026 22:31
61259e0 to
b5b3239
Compare
littlegrasscao
force-pushed
the
server/split2/11a-provider-pagination
branch
2 times, most recently
from
October 21, 2026 17:01
8de1044 to
8b7f3b9
Compare
littlegrasscao
force-pushed
the
server/split2/11a-provider-pagination
branch
2 times, most recently
from
October 21, 2026 17:13
ab948d3 to
d509dd4
Compare
Base automatically changed from
server/split2/11-recipient-activation
to
main
October 21, 2026 18:49
littlegrasscao
force-pushed
the
server/split2/11a-provider-pagination
branch
from
October 21, 2026 18:49
d509dd4 to
648f256
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /shares,GET /shares/{share}/permissions, andGET /recipientswith optionalmaxResultsandpageTokenquery parameters; responses carrynextPageTokenwhile more items remainmaxResultsis missing or 0, and never more; a negative size or a token this server did not issue isINVALID_PARAMETER_VALUE. Treating 0 as unset matches the list APIs of OSS Unity Catalog, which hosts these provider APIs; the recipient protocol lists keep the protocol's meaning of 0 (OpenSharing protocol: authenticate recipients and list granted shares #101)Paginationis a static helper in core with no settings, so neitherOpenSharing.Buildernorserver.propertiesconfigures page sizesPATCH /shares/{share}/permissionsreturns the first page of the share's permissionsTesting
mvn clean install: 121 tests passedPaginationTest: tokens walk a 1200-item list in pages of 500, larger sizes are capped at 500, 0 pages like a missing size, and negative sizes and foreign tokens are rejectedProviderListPaginationTest: withmaxResults=2, each list walks page by page in order without duplicates, PATCH permissions returns the first page,maxResults=0returns a full page, and a badmaxResultsorpageTokenis 400Stacked on #100.