Repository navigation
server: introduce USE_SHARE for reading other users' shares - #118
Merged
Merged
Conversation
littlegrasscao
force-pushed
the
server/split2/11b-use-share
branch
from
October 16, 2026 00:17
be79d9d to
aa8194f
Compare
littlegrasscao
force-pushed
the
server/split2/11b-use-share
branch
from
October 16, 2026 00:41
aa8194f to
0f527f3
Compare
littlegrasscao
force-pushed
the
server/split2/11b-use-share
branch
from
October 19, 2026 17:12
0f527f3 to
a4baf32
Compare
zhu-tom
added this pull request to stack #116
October 19, 2026 19:06
zhu-tom
approved these changes
Oct 19, 2026
littlegrasscao
force-pushed
the
server/split2/11b-use-share
branch
4 times, most recently
from
October 19, 2026 22:31
004c430 to
c20222a
Compare
littlegrasscao
force-pushed
the
server/split2/11b-use-share
branch
2 times, most recently
from
October 21, 2026 17:01
b71cd8c to
13e612a
Compare
Base automatically changed from
server/split2/11a-provider-pagination
to
main
October 21, 2026 18:51
littlegrasscao
force-pushed
the
server/split2/11b-use-share
branch
from
October 21, 2026 18:52
13e612a to
a6f75ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
USE_SHAREprivilege, checked throughCatalogConnector#authorizelikeCREATE_SHAREGET /shareslists every share for a caller withUSE_SHARE, and only the caller's own shares otherwise; paging works the same either wayGET /shares/{share}andGET /shares/{share}/permissionsneed the caller to own the share or holdUSE_SHARE; otherwise they return 403PERMISSION_DENIEDprivilegeslist and refuses privileges outside it; a principal without the list holds nonelocal-catalog.ymllistsCREATE_SHARE,CREATE_RECIPIENTandUSE_SHAREfor alice and bob, so earlier tests keep passing, and addscarol, who holds onlyCREATE_SHAREandCREATE_RECIPIENTTesting
mvn clean install: 123 tests passedShareReadPrivilegeTest:USE_SHARE, lists only her own share, while bob, who holdsUSE_SHARE, lists both alice's and carol's