Skip to content

Rohit - Fix Month-over-Month Percentage Labels in Lessons Learnt Chart - #5781

Open
RohSrik wants to merge 1 commit into
developmentfrom
Rohit_fix_lessons_mom_percentage
Open

RohSrik wants to merge 1 commit into
developmentfrom
Rohit_fix_lessons_mom_percentage

Conversation

@RohSrik

@RohSrik RohSrik commented Nov 5, 2026

Copy link
Copy Markdown

Description

Updated the Lessons Learnt chart to make the percentage labels easier to understand. Previously, the chart displayed MoM percentages without explaining what they represented, causing confusion when the total lesson count and monthly percentage change appeared together. This update adds a clear explanation and improves how unavailable percentage values are displayed.
image
image

Related PRS (if any):

Backend PR: #2469

Main changes explained:

  • Updated LessonsLearntChart.jsx to display N/A when the percentage is unavailable.
  • Added an explanation below the chart distinguishing lesson counts from MoM percentage changes.
  • Removed unused percentage conversion code.

How to test:

  1. Check out the Rohit_fix_lessons_mom_percentage branch in HighestGoodNetworkApp and HGNRest.
  2. Start both applications locally and log in.
  3. Navigate to BM Dashboard → Total Construction Summary → Lessons Learned → Lessons Learnt.
  4. Verify that the explanation appears below the chart.
  5. Select 10/01/2026 – 10/31/2026 and verify that N/A appears when September has zero lessons.
  6. Verify that positive and negative MoM percentages still display correctly.

Screenshots or videos of changes:

Before:
image

After:
image

image

Note:

  • This PR requires backend PR #2469 for the corrected percentage calculations.
  • Frontend ESLint and formatting checks passed.

@netlify

netlify Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 51168d3
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/6aecee705ab3e45747cf1e4d
😎 Deploy Preview https://deploy-preview-5781--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@sonarqubecloud

sonarqubecloud Bot commented Nov 5, 2026

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants