Repository navigation
Conversation
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Fixed incorrect month-over-month (MoM) percentages and date filtering in the Lessons Learnt chart. Previously, the API showed +100% when the previous month had zero lessons and excluded some lessons recorded on the selected end date.


Related PRS (if any):
Frontend: #5781
Main changes explained:
bmNewLessonController.jsto returnN/Ainstead of+100%when the previous month's count is zero.How to test:
Rohit_fix_lessons_mom_percentagebranch in HGNRest and HighestGoodNetworkApp.npm installif needed, then start the backend usingnpm run devand the frontend locally.N/Aappears when the previous month has zero lessons.Screenshots or videos of changes:
Before:

After:

Note: