Skip to content

Rohit - Fix Month-over-Month Percentage Labels in Lessons Learnt Chart #5781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RohSrik wants to merge 1 commit into
base: development
Choose a base branch
from
+8 −5
Open

Rohit - Fix Month-over-Month Percentage Labels in Lessons Learnt Chart #5781

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions src/components/BMDashboard/LessonsLearnt/LessonsLearntChart.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,7 @@ const useLessonsData = (selectedProjects, startDate, endDate) => {
projectName: item.project || 'Unknown Project',
projectId: item.projectId,
lessonsCount: item.lessonsCount || 0,
percentage:
Number.parseFloat((item.changePercentage || '0%').replace('%', '').replace('+', '')) ||
0,
changePercentage: item.changePercentage || '0%',
changePercentage: item.changePercentage ?? 'N/A',
}));

// When multiple projects selected, filter to only the chosen ones
Expand Down Expand Up @@ -201,7 +198,7 @@ function LessonsLearntChart({ darkMode: propDarkMode }) {
align: 'end',
offset: 2,
font: { weight: 'bold', size: 11 },
formatter: (_value, ctx) => lessonsData[ctx.dataIndex]?.changePercentage || '0%',
formatter: (_value, ctx) => lessonsData[ctx.dataIndex]?.changePercentage ?? 'N/A',
color: ctx => changeColor(lessonsData[ctx.dataIndex]?.changePercentage, darkMode),
},
},
Expand Down Expand Up @@ -362,6 +359,12 @@ function LessonsLearntChart({ darkMode: propDarkMode }) {
<div className={styles.barContainer}>
<Bar data={chartData} options={chartOptions} plugins={[ChartDataLabels]} />
</div>

<p className={styles.statusText}>
Bars show the number of lessons in the selected date range. MoM Change shows the
percentage change compared with the previous month. N/A means the previous month had
zero lessons, so a percentage increase cannot be calculated.
</p>
</>
)}
</div>
Expand Down
Loading