Test: regression for CIccCmm::CheckPCSConnections CIccPcsXform leak (#1337)

[colourbill-ctrl]

Summary

Adds a deterministic CTest regression for the CIccCmm::CheckPCSConnections CIccPcsXform leak fixed in #1338 (issue #1337). On an upstream branch because it touches .github/scripts/ + Build/Cmake/.

This fills the gap noted on #1338 (which shipped without a repro because the triggering chain lived only in the uncommitted 200-QA script). With that script now attached to #1337, I isolated a minimal, -PCC-free trigger — so this test is independent of the #1336 / #1339 fix.

What it does

Generates two profiles from committed XML (Testing/hybrid/CMYK-W_Overprint_Profile.xml, Testing/hybrid/Data/Spec380_10_730-D50_2deg.xml) and chains them:

iccApplyToLink <out>.cube 1 9 10 Issue1337 0.001 0.999 1 1 \
  <CMYK-W>.icc 1000 <Spec380>.icc 12

The CMYK→spectral PCS link is unsupported, so CheckPCSConnections' middle CIccPcsXform/Connect() fails (icCmmStatUnsupportedPcsLink) and — pre-fix — leaks the CIccPcsXform. Run under LeakSanitizer, the test fails on any leak report. The tool is expected to exit non-zero ("Unsupported PCS Link used"), so the pass/fail signal is the absence of a leak.

Verification

• Pre-fix (master without Fix: leak of CIccPcsXform in CIccCmm::CheckPCSConnections on Connect failure (#1337) #1338): ctest -R issue-1337 FAILS — 168 byte(s) leaked ... CheckPCSConnections.
• Post-fix (with Fix: leak of CIccPcsXform in CIccCmm::CheckPCSConnections on Connect failure (#1337) #1338): PASSES on both gcc and clang.

Context: full 200-QA sweep

Running the attached iccApplyToLink_QA_200.txt under LSan on master: 148 of 200 commands leak. With #1338 + #1339 applied, all 148 → 0 (the deeper Begin()-time sites were indirect children of the leaked -PCC profile / CIccPcsXform). This test pins the CheckPCSConnections half; #1340 pins the iccApplyToLink -PCC half.

Maintainer note — pairs with #1338. Merge #1338 first, then this PR (red until then by design). Hosted upstream because the fork-PR automation gate forbids fork PRs from .github/Build/Cmake.

🤖 Generated with Claude Code

[colourbill-ctrl]

Maintainer note — pairs with #1338. Merge #1338 first, then this PR. Expected red until then (branched off master without the fix; the CTest reproduces the 168-byte CheckPCSConnections leak). Upstream branch because the fork gate blocks fork PRs from .github/Build/Cmake.

[xsscx]

2026-06-14 04:52:12 UTC

[xsscx]

Job Failure

2026-06-14 04:55:00 UTC

The following tests FAILED:
Errors while running CTest
	 21 - iccdev.issue-1337-checkpcsconnections-regression (Failed)
Error: Process completed with exit code 8.

[xsscx]

Job Failure

2026-06-14 04:55:00 UTC

The following tests FAILED:
Errors while running CTest
21 - iccdev.issue-1337-checkpcsconnections-regression (Failed)
Error: Process completed with exit code 8.

[colourbill-ctrl]

Same pattern as #1340: the only failing check (CTest ASAN+UBSAN → iccdev.issue-1337-checkpcsconnections-regression) is the regression correctly detecting the unfixed CIccPcsXform leak on master. All other checks pass.

It flips green once the paired fix #1338 is merged. Suggested order: merge #1338 (fix) → re-run → merge #1341 (test).

[xsscx]

@colourbill-ctrl #1338 is Merged but latest Jon indicates Fail

[colourbill-ctrl]

Same cause as #1340, @xsscx — stale branch, not a real leak. This branch predated the #1338 merge, so its last CI run built the tools without the CIccPcsXform fix and the regression flagged the leak that #1338 removes.

Merged current master (now contains #1338 5355a02) into this branch and pushed; CI will rebuild with the fix.

Verified locally (clang-18, ASAN+UBSAN), fix now in tree:

Test #21: iccdev.issue-1337-checkpcsconnections-regression ... Passed  1.62 sec
100% tests passed, 0 tests failed out of 1

Should go green on the re-run.

[xsscx]

2026-06-14 21:40:28 UTC
Appears to need a rebase on master

[xsscx]

Merge Conflict

<<<<<<< test-1337-checkpcsconnections-regression
# Guards CIccCmm::CheckPCSConnections CIccPcsXform ownership on its Connect
# error path (#1337).  Generates two profiles from committed XML, chains them
# into an unsupported PCS link under LeakSanitizer, and fails on a leak.  No
# -PCC, so this is independent of the iccApplyToLink #1336 fix.
iccdev_add_script_test(
  iccdev.issue-1337-checkpcsconnections-regression
  120
  "iccdev;tools;cmm;leak;issue-1337;regression;asan"
  "${ICCDEV_REPO_ROOT}"
  "${ICCDEV_REPO_ROOT}/.github/scripts/iccdev-issue-1337-checkpcsconnections-regression.sh"
=======
# Guards iccApplyToLink -PCC profile ownership on its error-exit paths (#1336):
# drives the AddXform BadSpaceLink path with tracked profiles under LeakSanitizer
# and fails if a -PCC profile is stranded.  Uses committed test-data profiles, so
# no generated-profile fixture is required.
iccdev_add_script_test(
  iccdev.issue-1336-applytolink-pcc-regression
  60
  "iccdev;tools;applytolink;leak;issue-1336;regression;asan"
  "${ICCDEV_REPO_ROOT}"
  "${ICCDEV_REPO_ROOT}/.github/scripts/iccdev-issue-1336-applytolink-pcc-regression.sh"
>>>>>>> master

[colourbill-ctrl]

Resolved, @xsscx. The conflict was purely additive in Build/Cmake/Testing/CMakeLists.txt: the #1336 test (merged via #1340) and this #1337 test register adjacent iccdev_add_script_test(...) blocks. Kept both registrations. Verified the merged file configures and both tests run locally — iccdev.issue-1337-checkpcsconnections-regression Passed (fix #1338 is in master). Now mergeable.