Fix: leak of CIccPcsXform in CIccCmm::CheckPCSConnections on Connect failure (#1337)

[colourbill-ctrl]

Summary

Fixes the CIccCmm::CheckPCSConnections leak surfaced by the iccApplyToLink 200-QA ASan run (#1337):

Direct leak of 144 byte(s) in 1 object(s)
  #1 CIccCmm::CheckPCSConnections(bool)  IccProfLib/IccCmm.cpp
  #2 CIccCmm::Begin(bool, bool)
  #3 main  Tools/CmdLine/IccApplyToLink/iccApplyToLink.cpp

CheckPCSConnections builds up to three CIccPcsXform objects; each is either pushed onto the xform list (ownership transferred) or deleted. The middle block returned on a hard Connect() failure (rv != icCmmStatOk && rv != icCmmStatIdentityXform) without deleting the locally-owned pPcs — leaking it. The sibling ConnectFirst block above and the trailing block below both delete on their failure paths; this one was the outlier.

Fix

One line — delete pPcs; before the failure return, with comments documenting the ownership on each branch (transfer-to-list on success, discard on identity, free on failure).

Verification

• Code: the fix makes the middle block consistent with its two siblings (which already delete on failure); ASan log pinpoints this exact allocation site.
• No regression: the search -INIT success path (which exercises CheckPCSConnections' success/identity branches) stays ASan/LSan-clean.
• The specific Connect()-hard-failure chain that triggers the leak lives in the 200-QA profile set/script (not in-tree), so no deterministic CTest is added here; the change is a self-evident missing-delete mirroring the adjacent blocks.

Scope: this addresses the CheckPCSConnections library leak (#1337). The separate tool-level pccList/-PCC drop in iccApplyToLink.cpp (#1336) is a different path and not touched here.

🤖 Generated with Claude Code

[xsscx]

2026-06-14 01:50:43 UTC

[xsscx]

Note: Auto-Merge is On. Merge on your Schedule.

[colourbill-ctrl]

Now verified against a real trigger from the 200-QA (attached on #1337): a -PCC-free CMYK→spectral chain leaks 168 B via CheckPCSConnections pre-fix, clean post-fix. Regression added as #1341 (merge this first, then #1341). The full 200-QA goes 148→0 leaks with this PR + #1339.