Test: regression for signed->unsigned SeamlessIndicator conversion (#1342, #1343)

[colourbill-ctrl]

Summary

Deterministic CTest regression for #1342 and #1343 — the signed→unsigned SeamlessIndicator conversion in the Embedded Height/Normal image XML parsers. Pairs with fix PR #1344.

Replays the two fuzz PoCs (negative SeamlessIndicator) through iccFromXml and fails if the UBSan implicit-integer-sign-change finding reappears at CIccTagXmlEmbeddedHeightImage::ParseXml (#1342) or CIccTagXmlEmbeddedNormalImage::ParseXml (#1343).

What's added

• .github/scripts/iccdev-issue-1342-1343-imageparse-signed-unsigned-regression.sh
• .github/ci/test-data/ub-heightimage-parsexml-1342.xml and ub-normalimage-parsexml-1343.xml (the committed trigger PoCs)
• CTest registration iccdev.issue-1342-1343-imageparse-signed-unsigned-regression (label ubsan)

How it signals

The check is only meaningful under a build instrumented with the integer / implicit-conversion sanitizer. ci-iccdev-tool-tests builds with ENABLE_UBSAN=ON ENABLE_INTEGER_SANITIZER=ON (which adds -fno-sanitize-recover=integer), so pre-fix the conversion aborts the parse. The script inspects the build's CMakeCache.txt and skips cleanly on a non-sanitizer build rather than report a misleading pass. The pass/fail signal is the absence of the runtime error: implicit conversion line — not the tool exit code (the trigger profiles are intentionally invalid, so iccFromXml exits non-zero either way).

Verification

• FAILS pre-fix (both sites fire, exit 2) on the integer-sanitizer build
• PASSES post-fix (ctest -R 1342-1343 → 1/1 passed)
• SKIPS on a plain ASan-only build (CMakeCache gate)

Merge order

This test is red until #1344 (the fix) lands — same convention as prior fix/test splits. Merge #1344 first, then this.

🤖 Generated with Claude Code

[xsscx]

2026-06-14 19:01:43 UTC

[xsscx]

shellcheck

In .github/scripts/iccdev-issue-1342-1343-imageparse-signed-unsigned-regression.sh line 84:
  local log="$OUTDIR/$(basename "$xml").log"
        ^-^ SC2155 (warning): Declare and assign separately to avoid masking return values.

For more information:
  https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ...
[FAIL] shellcheck

[colourbill-ctrl]

Fixed the shellcheck SC2155 in 147cc25 — log is now declared and assigned separately so the $(basename …) exit status isn't masked. Pre-flight should go green on the next run.

The remaining CTest ASAN+UBSAN failure here is expected: the regression deliberately fails while the fix (#1344) is unmerged — it keys on UBSan's implicit conversion diagnostic, which is still present on master. It flips green once #1344 lands (merge fix → test, per the fork-gate split).

[xsscx]

2026-06-14 20:00:40 UTC

Auto-Merge is On.

[colourbill-ctrl]

@xsscx status on the one remaining red check (CTest ASAN+UBSAN):

This is expected red-by-design and is not yet stale — unlike #1340/#1341, the paired fix here (#1344) has not been merged yet. The regression deliberately fails while master still contains the signed→unsigned SeamlessIndicator UB, keying on UBSan's implicit conversion diagnostic.

Sequence to green:

1. merge fix Fix: signed->unsigned SeamlessIndicator conversion in image ParseXml (#1342, #1343) #1344
2. I refresh this branch with master (so its CI rebuilds with the fix)
3. CTest goes green → merge this test PR

(The earlier shellcheck SC2155 failure is already fixed in 147cc25; pre-flight is green.)

[xsscx]

Merge Conflict

<<<<<<< test-1342-1343-imageparse-signed-unsigned-regression
# Replays the #1342 / #1343 fuzz PoCs (negative SeamlessIndicator) through
# iccFromXml and fails if the signed->unsigned implicit conversion in the
# Embedded Height/Normal image ParseXml() handlers reappears.  Meaningful only
# under the integer/implicit-conversion sanitizer build (the script skips
# cleanly otherwise), so it carries the ubsan label.  No profile fixture needed
# -- the trigger XML files are committed test data.
iccdev_add_script_test(
  iccdev.issue-1342-1343-imageparse-signed-unsigned-regression
  120
  "iccdev;imageparse;signed-unsigned;regression;ubsan"
  "${ICCDEV_REPO_ROOT}"
  "${ICCDEV_REPO_ROOT}/.github/scripts/iccdev-issue-1342-1343-imageparse-signed-unsigned-regression.sh"
=======
# #1346: signed atoi() -> unsigned wrap in IccTagXml ParseXml handlers.
# Replays a PoC profile with a negative cicpFields ColorPrimaries attribute
# through iccFromXml; under the integer/implicit-conversion sanitizer the test
# FAILS if UBSan's implicit-integer-sign-change diagnostic reappears, and SKIPS
# cleanly on a plain (non-sanitizer) build.  Uses a committed PoC, so it needs
# no generated-profile fixture.
iccdev_add_script_test(
  iccdev.issue-1346-imageparse-atoi-unsigned-regression
  60
  "iccdev;xml;imageparse;issue-1346;regression;ubsan"
  "${ICCDEV_REPO_ROOT}"
  "${ICCDEV_REPO_ROOT}/.github/scripts/iccdev-issue-1346-imageparse-atoi-unsigned-regression.sh"
>>>>>>> master
)

[colourbill-ctrl]

Rebased onto current master and resolved the same additive CMakeLists conflict (the #1346 test merged via #1350 registers next to this #1342/#1343 test — kept both). Verified locally: both issue-1342-1343 and issue-1346 regressions Pass with their fixes in master.