Skip to content

refactor: move server startup into the library - #32

Open
gagantrivedi wants to merge 1 commit into
mainfrom
refactor/server-run
Open

gagantrivedi wants to merge 1 commit into
mainfrom
refactor/server-run

Conversation

@gagantrivedi

@gagantrivedi gagantrivedi commented Oct 31, 2026 •

Copy link
Copy Markdown
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Contributes to #14

Moves the server startup (logging, the no-environments warning, router, initial refresh, polling task, bind and serve) from main.rs into the library as edge_proxy::run(settings), so another binary can start the proxy without copying it. main.rs becomes one line. No behaviour change; the code and its comments moved as-is.

How did you test this code?

cargo fmt, cargo clippy -- -D warnings and the full test suite pass. main now only calls run with the settings it used to use inline.

@gagantrivedi gagantrivedi mentioned this pull request Oct 31, 2026
3 of 4 tasks
@coderabbitai

coderabbitai Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 0c71b3c8-bde8-4029-960a-1d20e9a54f20
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@gagantrivedi
gagantrivedi marked this pull request as ready for review October 31, 2026 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant