Repository navigation
feat: validate identity trait limits - #33
Open
gagantrivedi wants to merge 3 commits into
Open
gagantrivedi wants to merge 3 commits into
gagantrivedi wants to merge 3 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Contributes to #14
Stacked on #32.
{"status": "bad_request", "message": "traits[1].trait_value: ..."}. Previously identities had no request validation. Duplicate trait keys in a POST are de-duplicated, last value wins.transientflag onIdentityWithTraitsandTraitModel, as sent by SDKs. Parsed (defaultfalse), never serialized, and not part of identity equality.How did you test this code?
transient(de)serialization.cargo fmt,cargo clippy -- -D warningsand the full test suite pass on each commit.