chore!: bump Aztec to 6.0.0-rc.1 - #41
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
alejoamiras
marked this pull request as ready for review
September 28, 2026 18:50
Aztec 6 split its repositories and renamed its npm scope: - aztec-nr crates now come from aztec-labs-eng/aztec-nr (flat crate dirs); the escrow serde crate moved under noir-projects/fnd/ in aztec-packages. - @aztec/* SDK packages are now @aztec-labs/*, pinned exactly to 6.0.0-rc.1, and @aztec/bb.js is @aztec-foundation/bb.js. @aztec-labs/foundation and @aztec-foundation/bb.js become explicit devDeps (tests import both; they previously resolved only through hoisting). Source changes v6 forces: - DOM_SEP__PARTIAL_NOTE_COMMITMENT and DOM_SEP__NOTE_COMPLETION_LOG_TAG moved to aztec::note::partial_note (values unchanged). - The TXE aztec_txe_getPrivateEvents oracle returns BoundedVec<BoundedVec<..>> directly, so the escrow test stub drops its tuple-to-BoundedVec rebuild. - `aztec inspect-contract` was removed; drop the build's read-only inspection loop. BREAKING CHANGE: contract class ids and addresses change, and the generated wrappers import @aztec-labs/aztec.js. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rocedure README: the published package declares no dependencies, and its wrappers now import @aztec-labs/aztec.js. bump-aztec-version skill: v6 repo split (aztec-nr, fnd/ protocol crates, @aztec-labs npm scope), exact pins, isolated toolchain install, the fixed TXE port, nargo's workspace-root pitfall in nested worktrees, the TXE oracle stub shape, removed CLI commands, the CI Node floor, and aztec-benchmark peers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
alejoamiras
force-pushed
the
worktree-aztec-v6-bump
branch
from
September 29, 2026 15:18
4f86cfd to
f2a5d16
Compare
alejoamiras
changed the base branch from
stack/closeout-nft-notehash
to
main
September 29, 2026 15:18
Benchmark Comparison
Contract: escrow
Contract: logic
Contract: multitoken
Contract: nft
Contract: token
Contract: vault
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
iAmMichaelConnor
approved these changes
Sep 29, 2026
| // Source: https://github.com/AztecProtocol/aztec-packages/blob/v5.1.0/noir-projects/aztec-nr/aztec/src/test/helpers/txe_oracles.nr#L42-L43 | ||
| // (`MAX_PRIVATE_EVENTS_PER_TXE_QUERY` and `MAX_EVENT_SERIALIZATION_LENGTH` are still module-private there, so not importable; | ||
| // values re-verified unchanged at v5.1.0.) | ||
| // aztec-nr's `txe_oracles::get_private_events` is crate-private, so this duplicates its oracle. The oracle's return |
Collaborator
There was a problem hiding this comment.
(Not needed for this PR, but...) this sounds like a hack?
Collaborator
Author
There was a problem hiding this comment.
Yeah, agreed - it's a hack, and it was already there before this PR. aztec-nr keeps txe_oracles::get_private_events as pub(crate) (still the case on aztec-node main), so there's no public way for a contract's TXE tests to read the private events a call emitted. This PR just updated the copy's return type for rc.1.
- Opened an issue upstream asking for a public reader: [FEATURE] aztec-nr: expose
get_private_eventsto contract tests on TXE aztec-labs-eng/aztec-node#363 - test(escrow): drop the copied TXE private-events oracle #42 drops the copy - the only test using it was checking the same event we already check in
escrow.test.tswithwallet.getPrivateEvents.
This was referenced Sep 29, 2026
[FEATURE] aztec-nr: expose
get_private_events to contract tests on TXE
aztec-labs-eng/aztec-node#363
Open
alejoamiras
added a commit
that referenced
this pull request
Sep 30, 2026
v6.0.0-rc.1 shows as Unverified on GitHub. Its tag is lightweight, so GitHub shows the tagged commit's signature, and that commit is unsigned: #41 was rebase-merged, and GitHub re-creates rebase-merged commits without a signature. Step 3 now records the commit to release as SHA and aborts unless GitHub reports a verified signature on it; Step 4 tags that exact SHA, so a later checkout can't swap in an unchecked commit. The rc flow signs its rehearse commit and pushes the branch so GitHub can verify it before the tag exists. A new gotcha says to squash-merge into main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves every contract, test, script and dependency from Aztec 5.2.0 to 6.0.0-rc.1, with only the changes v6 forces.
What changes
aztec-labs-eng/aztec-nr(flat crate dirs). Escrow'sserdemoved tonoir-projects/fnd/noir-protocol-circuits/crates/serdein aztec-packages.@aztec/*→@aztec-labs/*pinned exactly to6.0.0-rc.1(thelatestdist-tag points at a stale nightly), and@aztec/bb.js→@aztec-foundation/bb.js.@aztec-labs/foundationand@aztec-foundation/bb.jsbecome explicit devDeps: tests import both, and they previously resolved only through hoisting.DOM_SEP__PARTIAL_NOTE_COMMITMENTandDOM_SEP__NOTE_COMPLETION_LOG_TAGare now imported fromaztec::note::partial_note; their values are unchanged. The escrow test's copy of the crate-private TXE oracleaztec_txe_getPrivateEventsnow returnsBoundedVec<BoundedVec<Field, 10>, 5>directly, matching rc.1.aztec inspect-contract, so the build's read-only inspection loop is gone. The.bakcleanup stays becausebb aztec_processstill emits them.bump-aztec-versionskill for v6's repo split, isolated installs, fixed test ports, and verification by tag → SHA.Breaking changes
@aztec-labs/aztec.js. The package still declares no dependencies, so consumers install it atconfig.aztecVersion.Upstream pins
Nargo pins by tag only, and tags can move. These are the commits the tags resolved to, verified with
git ls-remoteand against the nargo checkouts that were compiled:aztec-labs-eng/aztec-nrv6.0.0-rc.188ff1ded43051ed5393150799f4308aeda46e94aAztecProtocol/aztec-packagesv6.0.0-rc.1d521f0d940d096fbea5b62010d9c9c70f1dc0fd2@aztec-labs/*,@aztec-foundation/bb.js6.0.0-rc.1Validation
All run locally against the rc.1 toolchain, at this branch's HEAD:
aztec compile, plus 433/433 tests on a TXE. The executed<package>::<test>set is identical to the base's, including the escrow key-derivation vector tests; the vectors are untouched.yarn test:js) against a local rc.1 network, including the escrow TS↔Noir key-derivation cross-check.aztec-benchmark5.0.1. Its peer range says<6, and yarn only warns; its dist has no runtime@aztec/*imports.yarn build,npm publish --dry-run --tag rc, and a plain-Node import of the builtTokenwrapper. The export layout is identical to the published 5.2.0 tarball.@aztec-labs/*,@aztec-foundation/*); no third-party dependency is younger than 7 days.Caveats / follow-ups
aztec-ci-actions'setup-aztecstill pinssetup-nodeto 24.0.0, below v6's ≥ 24.12. CI doesn't break: the v6 installer installs its own Node, and every job passes.variable does not need to be mutablewarnings (v6'sTestEnvironmentno longer needs&mut).🤖 Generated with Claude Code