docs: release skill never re-creates a tag and only tags a verified commit - #43
Open
alejoamiras wants to merge 2 commits into
Open
alejoamiras wants to merge 2 commits into
alejoamiras wants to merge 2 commits into
Conversation
Step 4 deleted the remote tag before every push, so re-running it after a publish would move a published version's tag off the commit its provenance names. It now stops if the version is already on npm, if npm can't be reached, or if the tag already exists on origin or origin can't be reached. The tag is created with --no-sign so a machine with tag.gpgSign=true still makes a lightweight tag instead of opening an editor for a signed annotated one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
v6.0.0-rc.1 shows as Unverified on GitHub. Its tag is lightweight, so GitHub shows the tagged commit's signature, and that commit is unsigned: #41 was rebase-merged, and GitHub re-creates rebase-merged commits without a signature. Step 3 now records the commit to release as SHA and aborts unless GitHub reports a verified signature on it; Step 4 tags that exact SHA, so a later checkout can't swap in an unchecked commit. The rc flow signs its rehearse commit and pushes the branch so GitHub can verify it before the tag exists. A new gotcha says to squash-merge into main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
alejoamiras
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes to the release skill's tagging step.
v6.0.0-rc.1shows as Unverified: release tags are lightweight, so GitHub shows the commit's signature, and chore!: bump Aztec to 6.0.0-rc.1 #41 was rebase-merged, which strips it. Step 3 now records the SHA and stops unless GitHub reports it verified, and Step 4 tags that exact SHA. Tags stay lightweight (--no-sign).Repo settings changed alongside this: squash-only merges, and signed commits required on
main.Tested both guards under
bash -eagainst real cases: rc.1 already on npm, an existing tag, a new version, npm or origin down, and the unsigned rc.1 commit vs signed ones.🤖 Generated with Claude Code