Skip to content

test(escrow): drop the copied TXE private-events oracle - #42

Open
alejoamiras wants to merge 1 commit into
mainfrom
worktree-drop-txe-event-stub
Open

test(escrow): drop the copied TXE private-events oracle#42
alejoamiras wants to merge 1 commit into
mainfrom
worktree-drop-txe-event-stub

Conversation

@alejoamiras

@alejoamiras alejoamiras commented Sep 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Drops our hand-copied aztec_txe_getPrivateEvents oracle from the escrow test utils. aztec-nr keeps its TXE reader pub(crate), so the copy was the only way to read private events in a contract test - and it breaks whenever the oracle changes shape (it already needed a return-type fix for rc.1).

🤖 Generated with Claude Code

@github-actions

This comment has been minimized.

Sign in to view
@alejoamiras @claude
test(escrow): drop the copied TXE private-events oracle
5e48ae5 
aztec-nr keeps `txe_oracles::get_private_events` crate-private, so the
test_logic crate re-declared the `aztec_txe_getPrivateEvents` oracle and its
bounds by hand, and every Aztec bump had to re-sync them (v6 changed the
return type). Its only consumer, `share_escrow_success`, asserted the same
event that escrow.test.ts already checks end to end through
`wallet.getPrivateEvents`. The copy goes; the Noir test still checks that
`share_escrow` succeeds, and the bump skill loses the matching gotcha.

Upstream request for a public reader: aztec-labs-eng/aztec-node#363.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@alejoamiras
alejoamiras force-pushed the worktree-drop-txe-event-stub branch from df1c86b to 5e48ae5 Compare September 29, 2026 20:35
@alejoamiras
alejoamiras changed the base branch from worktree-aztec-v6-bump to main September 29, 2026 20:35
@alejoamiras
alejoamiras marked this pull request as ready for review September 29, 2026 20:36
@github-actions

github-actions Bot commented Sep 29, 2026

Copy link
Copy Markdown

Benchmark Comparison

CPU Cores RAM Arch
Intel(R) Xeon(R) 6973P-C 4 16 GiB x64

Contract: escrow

🚦 Function Gates DA Gas L2 Gas Proving Time (ms)
Base PR Diff Base PR Diff Base PR Diff Base PR Diff
⚪ (partial) withdraw 354,645 354,645 3,744 3,744 587,800 587,800 4,974 5,640 +666 (+13.4%)
⚪ withdraw 270,326 270,326 832 832 499,700 499,700 3,968 4,687 +719 (+18.1%)
⚪ withdraw_nft 266,680 266,680 1,440 1,440 527,400 527,400 4,084 4,840 +756 (+18.5%)

Contract: logic

🚦 Function Gates DA Gas L2 Gas Proving Time (ms)
Base PR Diff Base PR Diff Base PR Diff Base PR Diff
⚪ get_escrow 298,866 298,866 192 192 456,000 456,000 4,376 5,204 +828 (+18.9%)
⚪ secret_key_to_public_keys 296,331 296,331 192 192 456,000 456,000 4,592 5,176 +584 (+12.7%)
⚪ share_escrow 245,424 245,424 1,952 1,952 520,700 520,700 3,840 4,507 +667 (+17.4%)

Contract: multitoken

🚦 Function Gates DA Gas L2 Gas Proving Time (ms)
Base PR Diff Base PR Diff Base PR Diff Base PR Diff
⚪ burn_private 222,468 222,468 832 832 499,700 499,700 3,724 4,194 +470 (+12.6%)
⚪ burn_public 185,539 185,539 416 416 638,286 638,286 3,508 4,011 +503 (+14.3%)
⚪ initialize_transfer_commitment 188,484 188,484 768 768 474,500 474,500 3,446 3,948 +502 (+14.6%)
⚪ mint_to_private 239,217 239,217 1,408 1,408 511,400 511,400 3,770 4,772 +1,002 (+26.6%)
⚪ mint_to_public 185,539 185,539 416 416 637,794 637,794 3,357 3,970 +613 (+18.3%)
⚪ transfer_private_to_commitment 225,577 225,577 1,024 1,024 511,400 511,400 3,751 4,257 +506 (+13.5%)
⚪ transfer_private_to_private 278,917 278,917 2,048 2,048 555,100 555,100 4,196 4,755 +559 (+13.3%)
⚪ transfer_private_to_public 254,364 254,364 1,056 1,056 714,671 714,671 3,964 4,602 +638 (+16.1%)
⚪ transfer_public_to_commitment 185,539 185,539 640 640 663,507 663,507 3,435 3,998 +563 (+16.4%)
⚪ transfer_public_to_private 246,797 246,797 1,024 1,024 683,952 683,952 4,212 4,540 +328 (+7.8%)
⚪ transfer_public_to_public 185,539 185,539 480 480 673,499 673,499 3,371 3,984 +613 (+18.2%)

Contract: nft

🚦 Function Gates DA Gas L2 Gas Proving Time (ms)
Base PR Diff Base PR Diff Base PR Diff Base PR Diff
⚪ burn_private 223,523 223,523 416 416 661,046 661,046 3,815 4,407 +592 (+15.5%)
⚪ burn_public 185,539 185,539 448 448 670,028 670,028 3,333 3,964 +631 (+18.9%)
⚪ mint_to_private 268,061 268,061 1,600 1,600 735,336 735,336 4,149 5,283 +1,134 (+27.3%)
⚪ mint_to_public 185,539 185,539 448 448 670,712 670,712 3,374 3,974 +600 (+17.8%)
⚪ transfer_private_to_private 211,981 211,981 832 832 499,700 499,700 3,523 4,163 +640 (+18.2%)
⚪ transfer_private_to_public 223,550 223,550 416 416 659,252 659,252 3,741 4,378 +637 (+17.0%)
⚪ transfer_public_to_private 240,913 240,913 992 992 683,262 683,262 3,834 4,513 +679 (+17.7%)
⚪ transfer_public_to_public 185,539 185,539 384 384 633,279 633,279 3,369 3,983 +614 (+18.2%)

Contract: token

🚦 Function Gates DA Gas L2 Gas Proving Time (ms)
Base PR Diff Base PR Diff Base PR Diff Base PR Diff
⚪ burn_private 250,779 250,779 1,024 1,024 713,951 713,951 3,916 4,590 +674 (+17.2%)
⚪ burn_public 185,539 185,539 448 448 672,626 672,626 3,364 3,976 +612 (+18.2%)
⚪ initialize_transfer_commitment 188,484 188,484 768 768 474,500 474,500 3,404 3,981 +577 (+17.0%)
⚪ mint_to_private 281,953 281,953 2,144 2,144 738,064 738,064 4,441 4,914 +473 (+10.7%)
⚪ mint_to_public 185,539 185,539 448 448 672,221 672,221 3,489 4,121 +632 (+18.1%)
⚪ transfer_private_to_commitment 222,045 222,045 992 992 511,400 511,400 3,651 4,251 +600 (+16.4%)
⚪ transfer_private_to_private 286,325 286,325 2,592 2,592 557,600 557,600 4,318 4,816 +498 (+11.5%)
⚪ transfer_private_to_public 250,831 250,831 1,024 1,024 714,017 714,017 4,060 4,603 +543 (+13.4%)
⚪ transfer_private_to_public_with_commitment 254,753 254,753 1,600 1,600 747,317 747,317 4,148 4,655 +507 (+12.2%)
⚪ transfer_public_to_commitment 185,539 185,539 576 576 662,520 662,520 3,356 3,981 +625 (+18.6%)
⚪ transfer_public_to_private 244,762 244,762 992 992 683,298 683,298 4,026 4,538 +512 (+12.7%)
⚪ transfer_public_to_public 185,539 185,539 448 448 672,542 672,542 3,475 3,984 +509 (+14.6%)

Contract: vault

🚦 Function Gates DA Gas L2 Gas Proving Time (ms)
Base PR Diff Base PR Diff Base PR Diff Base PR Diff
⚪ deposit_private_to_private 362,767 362,767 1,312 1,312 878,227 878,227 5,331 5,793 +462 (+8.7%)
⚪ deposit_private_to_private_exact 471,194 471,194 1,888 1,888 915,295 915,295 7,030 7,249 +219 (+3.1%)
⚪ deposit_private_to_public 308,983 308,983 768 768 862,252 862,252 4,705 5,223 +518 (+11.0%)
⚪ deposit_public_to_private 298,960 298,960 1,984 1,984 965,024 965,024 4,850 5,165 +315 (+6.5%)
⚪ deposit_public_to_private_exact 301,691 301,691 1,952 1,952 949,448 949,448 4,627 5,162 +535 (+11.6%)
⚪ deposit_public_to_public 185,539 185,539 832 832 897,542 897,542 3,580 3,975 +395 (+11.0%)
⚪ issue_private_to_private_exact 471,194 471,194 1,888 1,888 915,955 915,955 5,829 6,917 +1,088 (+18.7%)
⚪ issue_private_to_public_exact 339,595 339,595 1,344 1,344 899,977 899,977 4,677 5,690 +1,013 (+21.7%)
⚪ issue_public_to_private 275,652 275,652 1,376 1,376 921,640 921,640 4,316 4,872 +556 (+12.9%)
⚪ issue_public_to_public 185,539 185,539 832 832 898,232 898,232 3,486 3,982 +496 (+14.2%)
⚪ redeem_private_to_private_exact 474,161 474,161 1,888 1,888 915,802 915,802 6,673 6,942 +269 (+4.0%)
⚪ redeem_private_to_public 308,930 308,930 768 768 862,696 862,696 4,962 5,210 +248 (+5.0%)
⚪ redeem_public_to_private_exact 304,711 304,711 1,952 1,952 949,769 949,769 4,404 5,189 +785 (+17.8%)
⚪ redeem_public_to_public 185,539 185,539 832 832 898,064 898,064 3,759 3,958 +199 (+5.3%)
⚪ withdraw_private_to_private 365,734 365,734 1,312 1,312 878,437 878,437 5,625 5,782 +157 (+2.8%)
⚪ withdraw_private_to_private_exact 474,161 474,161 1,888 1,888 915,748 915,748 6,621 6,937 +316 (+4.8%)
⚪ withdraw_private_to_public_exact 339,542 339,542 1,344 1,344 900,211 900,211 5,546 5,608 +62 (+1.1%)
⚪ withdraw_public_to_private 314,923 314,923 2,528 2,528 967,335 967,335 5,095 5,289 +194 (+3.8%)
⚪ withdraw_public_to_public 185,539 185,539 832 832 898,367 898,367 3,350 3,968 +618 (+18.4%)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iAmMichaelConnor iAmMichaelConnor Awaiting requested review from iAmMichaelConnor
@IlyasRidhuan IlyasRidhuan Awaiting requested review from IlyasRidhuan

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@alejoamiras