intent: Count runs from disabled selected workflows - #401
Conversation
…ntent/disabled-workflow-run-counting
Deploying ystack with
|
| Latest commit: |
34dfb97
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4ebc2375.fabrica-6yx.pages.dev |
| Branch Preview URL: | https://ystack-intent-disabled-workf.fabrica-6yx.pages.dev |
|
Independent G1 review — PR #401 Reviewer: Repository: Reviewed-head: 34dfb97 Evidence and review boundary. I read the complete 60-line intent, complete PR diff and description, applicable G1 stage criteria, current working/review rules and program authorization. I checked the intent against the current quota helper, its complete existing hermetic test, and the already implemented run-attempt identity behavior. Before and after substantive review, independently fetched API values showed the same head, base, PR title/body and intake hashes above. Hashes cover the issue’s exact non-null UTF-8 title/body without normalization or added newline. PR #401 remained open with no labels, so Current acceptance is comment 5772185718, independently read from the API and verified as authored by Bugs pass — no Important findings. The intent identifies the remaining source defect accurately. The helper queries selected workflows without The intended behavior is precise: eligible runs from a disabled selected workflow contribute to the existing window and combined threshold decision. Selection, threshold comparison, exclusions, fetch-limit scaling, missing-workflow treatment, error handling and configuration precedence remain unchanged. The proposed behavioral proof is appropriate for G1. It requires a hermetic regression showing that previously omitted runs affect the actual count and threshold result, rather than merely matching a command string. Fixture details and boundary-case selection remain explicit design questions for G2. The original run-attempt identity requirement is already implemented and is correctly retained as a constraint. No duplicate repair or workflow change is proposed. Security pass — no Important findings. The prospective concern stays within the existing quota helper and its existing test. Global listing failures, unexpected per-workflow failures and invalid numeric counts remain failures; errors cannot silently become zero usage. The intent excludes workflow changes, probe publication, permissions, executable selection, quota-policy changes, credentials, provider operations, installation, activation and target execution. It grants no new operational authority. Hermetic behavioral evidence does not require enabling, disabling or invoking a real workflow. Compliance pass — no Important findings. Only The artifact follows the G1 template, states the problem and bounded outcome in plain language, identifies affected systems, preserves safety constraints and leaves implementation details to design. It tracks #132 without closing it. It contains no review-round history or premature implementation-success claim. The PR description records one G2 must still accept the design and explicit risk classification. The applicable independent plan gate, implementation proof and required reviews remain necessary before code or completion. Preserved history verified. The reviewed head is a normal two-parent merge:
The original intent commit has parent Source blobs used for comparison:
CI and conclusion. The API reports quick-CI run 35695455155 completed successfully at the reviewed head. This reports the observed automatic run, not full-suite or implementation proof. The manager must still verify required checks and unchanged identities immediately before any protected merge. No Important findings or nits. Accept this exact intent at G1. This is not G2, plan, implementation or merge authorization. This reviewer made no file, ref, worktree, comment, label or other state changes and executed no tests or targets. Review-verdict: ACCEPT |
1 participant
The quota preflight currently omits runs when a selected workflow becomes disabled. This intent defines the remaining repair: include those runs in the existing count while preserving selection, thresholds, exclusions and error handling.
Tracks #132.
Current intake acceptance: #132 (comment)
review_size: standard
Only
work/disabled-workflow-run-counting/intent.mdchanges. The original 60-line draft and its branch are preserved; a normal merge refreshes its base. No implementation, workflow, installation or activation is included.Validation: exact intent blob and merge parents verified, clean checkout and whitespace check. Required quick CI and fresh independent G1 review are pending; this is not implementation acceptance.