plan: Count runs from disabled selected workflows

[yihanzhu]

This plan fixes omitted runs from disabled selected workflows by using the existing CLI option and proving the resulting total and threshold decision in the current hermetic suite.

Tracks #132. Accepted intent: #401. Accepted high-risk spec: #402.

review_size: standard

Only work/disabled-workflow-run-counting/plan.md changes. The implementation is limited to the existing quota helper and its test. Preserve the failing pre-fix regression, all existing assertions, pinned lint and the required quick CI gate.

Validation: plan-only history, exact artifact hash chain, clean checkout and whitespace check verified. Independent plan acceptance and required quick CI are pending. No implementation or live operation is included.

[yihanzhu]

Independent high-risk plan review — PR #403

Reviewer: /root/package_rebinding_intent_author, independent of plan author /root/disabled_workflow_spec_author. Requested model/effort: gpt-6-astra / high; actual runtime identity is not independently exposed.

Repository: yihanzhu/ystack
PR: #403
Branch: ystack/plan/disabled-workflow-run-counting
Gate mode: artifact-high
Accepted risk: high

Reviewed-head: 7528a8b
Reviewed-base: 7c6b653
Plan-blob: 831be531bd96c1f0e123820357a6c55b3d88a26e
Spec-blob: c70ccd50c18858f8165da66d5dce64707d1cbbe1
Intent-blob: d9bd79f672384b5b97d43ab96e9165038fb5d3c3
Intake-title-sha256: 8d8797714fd0b602d816d0e6fb9ad3499faa3b10e797104f4486dfbec12629d5
Intake-body-sha256: 628e11bfe6ede8a92d47bef7a7953cbe7b67610d90dfa87c235a23b057012809

Evidence and identity.

I read the complete 71-line plan and compared it with the accepted spec, intent, current helper and existing test. Applicable working rules, high-risk plan criteria and CI-minimum policy were checked.

Independent API reads before and after review returned unchanged PR head, base, title/body and intake hashes. Issue #132 remained open. PR #403 remained open with no labels; merge-ready was absent. Final remote reads matched the reviewed main and plan heads.

G2 PR #402 is merged at the reviewed base. The plan’s spec-blob matches that accepted spec, its intent-blob matches the accepted intent, and its frontmatter records risk: high. Current intake acceptance remains the manager-verified record at comment 5772185718.

Bugs pass — no Important findings.

The plan names the two real implementation paths and preserves the spec’s narrow repair: add --all only to the existing selected-workflow query. It leaves the global sanity query, other arguments, selection, accumulation and errors unchanged.

The order makes the regression meaningful. Extend the existing stub, invoke the real helper with enabled/disabled counts of 3+16 and 3+17, retain the original helper’s failing result, then apply the query fix. The planned assertions require both the actual totals and exit statuses, plus the existing threshold diagnostic. This detects omitted disabled runs rather than merely checking an argument string.

The plan preserves every existing fixture mode and assertion and requires the complete affected suite on the final committed implementation. It identifies concrete commands for that suite, pinned ShellCheck and whitespace checking. A separate implementer can follow the plan without inventing scope or proof requirements.

Security pass — no Important findings.

The plan identifies the relevant safety boundary: hidden workflows must be counted without weakening refusal of genuine listing or numeric-result failures. It preserves the threshold, window, exclusions, fetch-limit scaling, configuration precedence and existing run-attempt identity.

No workflow, quota-policy, credential, provider-operation, installation, activation or target authority expands. The existing helper and hermetic fixture remain the boundaries. No new framework, dependency or exceptional implementation path is proposed.

Compliance pass — no Important findings.

The branch contains exactly one non-merge commit beyond the accepted base. I inspected its changed paths: only work/disabled-workflow-run-counting/plan.md. Its sole parent equals the reviewed base. The final diff is also plan-only; no code-then-revert history appears.

The worktree is clean, whitespace checking passes, and implementation source remains unchanged. No matching local, remote-tracking or remote implementation branch was found.

The plan requires independent review and merge before implementation, followed by verification of the current base and artifact chain through the existing high-risk gate before the first code commit. Accepted artifacts remain unchanged during implementation.

The PR tracks #132 rather than closing it. Standard review size is recorded, the artifact contains normative content rather than round history, and its requirements match the accepted spec. Plain-language scope and proof are proportionate to the repair.

The CI requirement correctly follows work/ci-minimum-roadmap/decision.md: complete relevant helper proof, required quick CI and independent implementation review. This isolated repair adds no full-matrix milestone and does not excuse any existing milestone’s proof.

CI and conclusion.

The API reports quick-CI run 35697460487 completed successfully at the reviewed head. This is observed automatic CI, not implementation or full-suite proof. The manager must verify required checks and unchanged identities immediately before protected merge.

No Important findings or nits. Accept this exact high-risk plan. Implementation remains behind its protected merge and the current-base pre-code gate.

This reviewer changed no files, refs, worktrees, comments, labels or other state and executed no tests or targets.

Plan-verdict: ACCEPT