Skip to content

chore(deps)!: upgrade to utopia-php/domains 3.x #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loks0n merged 2 commits into from
Jul 31, 2026
Merged

chore(deps)!: upgrade to utopia-php/domains 3.x #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1117a5f
chore(deps)!: upgrade to utopia-php/domains 3.x
loks0n Jul 31, 2026
b49aee3
ci: test on PHP 8.4 and 8.5
loks0n Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
php-versions: ['8.1', '8.2', '8.3', 'nightly']
php-versions: ['8.4', '8.5', 'nightly']

steps:
- name: Checkout repository
Expand Down
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@
"import:stats": "php import.php stats"

@greptile-apps greptile-apps Bot Jul 31, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Documented PHP minimum is stale

The package now requires PHP 8.4, while README.md and CONTRIBUTING.md still advertise PHP 8.0 or later. Users following those requirements on PHP 8.0–8.3 receive a Composer platform conflict, so the installation and contributor documentation should be updated with this requirement bump.

Prompt To Fix With AI 
This is a comment left during a code review.
Path: composer.json
Line: 25

Comment:
**Documented PHP minimum is stale**

The package now requires PHP 8.4, while README.md and CONTRIBUTING.md still advertise PHP 8.0 or later. Users following those requirements on PHP 8.0–8.3 receive a Composer platform conflict, so the installation and contributor documentation should be updated with this requirement bump.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Fix in Claude Code Fix in Codex

@greptile-apps greptile-apps Bot Jul 31, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 CI targets unsupported PHP versions

The package now requires PHP 8.4, but the test matrix still runs PHP 8.1, 8.2, 8.3, and nightly while bypassing platform checks with --ignore-platform-reqs. This spends most test coverage on unsupported runtimes and does not explicitly validate the newly supported minimum, so the matrix should be aligned with PHP 8.4.

Prompt To Fix With AI 
This is a comment left during a code review.
Path: composer.json
Line: 25

Comment:
**CI targets unsupported PHP versions**

The package now requires PHP 8.4, but the test matrix still runs PHP 8.1, 8.2, 8.3, and nightly while bypassing platform checks with `--ignore-platform-reqs`. This spends most test coverage on unsupported runtimes and does not explicitly validate the newly supported minimum, so the matrix should be aligned with PHP 8.4.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Fix in Claude Code Fix in Codex

},
"require": {
"php": ">=8.0",
"php": ">=8.4",
"utopia-php/validators": "0.*",
"utopia-php/domains": "^2.0"
"utopia-php/domains": "^3.0"
},
"require-dev": {
"laravel/pint": "1.25.*",
Expand Down
75 changes: 37 additions & 38 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading