chore(deps)!: upgrade to utopia-php/domains 3.x - #22
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Greptile SummaryRaises the package runtime and dependency baseline.
Confidence Score: 4/5The PR should not merge until the user and contributor documentation reflects the new PHP 8.4 minimum. The CI matrix is now aligned with supported runtimes, but README.md and CONTRIBUTING.md still tell users that PHP 8.0 is supported, leading installations and contributor setup on PHP 8.0–8.3 to fail Composer platform resolution. Files Needing Attention: README.md and CONTRIBUTING.md Important Files Changed
Reviews (2): Last reviewed commit: "ci: test on PHP 8.4 and 8.5" | Re-trigger Greptile |
| @@ -25,9 +25,9 @@ | |||
| "import:stats": "php import.php stats" | |||
There was a problem hiding this comment.
Documented PHP minimum is stale
The package now requires PHP 8.4, while README.md and CONTRIBUTING.md still advertise PHP 8.0 or later. Users following those requirements on PHP 8.0–8.3 receive a Composer platform conflict, so the installation and contributor documentation should be updated with this requirement bump.
Prompt To Fix With AI
This is a comment left during a code review.
Path: composer.json
Line: 25
Comment:
**Documented PHP minimum is stale**
The package now requires PHP 8.4, while README.md and CONTRIBUTING.md still advertise PHP 8.0 or later. Users following those requirements on PHP 8.0–8.3 receive a Composer platform conflict, so the installation and contributor documentation should be updated with this requirement bump.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.| @@ -25,9 +25,9 @@ | |||
| "import:stats": "php import.php stats" | |||
There was a problem hiding this comment.
CI targets unsupported PHP versions
The package now requires PHP 8.4, but the test matrix still runs PHP 8.1, 8.2, 8.3, and nightly while bypassing platform checks with --ignore-platform-reqs. This spends most test coverage on unsupported runtimes and does not explicitly validate the newly supported minimum, so the matrix should be aligned with PHP 8.4.
Prompt To Fix With AI
This is a comment left during a code review.
Path: composer.json
Line: 25
Comment:
**CI targets unsupported PHP versions**
The package now requires PHP 8.4, but the test matrix still runs PHP 8.1, 8.2, 8.3, and nightly while bypassing platform checks with `--ignore-platform-reqs`. This spends most test coverage on unsupported runtimes and does not explicitly validate the newly supported minimum, so the matrix should be aligned with PHP 8.4.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
utopia-php/domains3.0.0 raises its own minimum to PHP 8.4 and moves ontoutopia-php/cache4.x (and transitivelyutopia-php/pools2.x). Its API is otherwise unchanged, so this needs no code changes here — only the requirement bump, the matchingphpminimum (>=8.0→>=8.4, since domains 3 will not install below that), and the lock refresh.Needed so that appwrite/appwrite can move to pools 2 —
utopia-php/emailspinsdomains ^2.0and blocks resolution.🤖 Generated with Claude Code