Skip to content

chore(deps)!: upgrade to utopia-php/domains 3.x - #22

Merged
loks0n merged 2 commits into
mainfrom
chore/domains-3
Jul 31, 2026
Merged

chore(deps)!: upgrade to utopia-php/domains 3.x#22
loks0n merged 2 commits into
mainfrom
chore/domains-3

Conversation

@loks0n

@loks0n loks0n commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

utopia-php/domains 3.0.0 raises its own minimum to PHP 8.4 and moves onto utopia-php/cache 4.x (and transitively utopia-php/pools 2.x). Its API is otherwise unchanged, so this needs no code changes here — only the requirement bump, the matching php minimum (>=8.0>=8.4, since domains 3 will not install below that), and the lock refresh.

Needed so that appwrite/appwrite can move to pools 2 — utopia-php/emails pins domains ^2.0 and blocks resolution.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Jul 31, 2026

Copy link
Copy Markdown

Greptile Summary

Raises the package runtime and dependency baseline.

  • Requires PHP 8.4 or later and utopia-php/domains 3.x.
  • Refreshes the lockfile to cache 4.x, pools 2.x, and related transitive dependencies.
  • Updates the test matrix to PHP 8.4, PHP 8.5, and nightly.

Confidence Score: 4/5

The PR should not merge until the user and contributor documentation reflects the new PHP 8.4 minimum.

The CI matrix is now aligned with supported runtimes, but README.md and CONTRIBUTING.md still tell users that PHP 8.0 is supported, leading installations and contributor setup on PHP 8.0–8.3 to fail Composer platform resolution.

Files Needing Attention: README.md and CONTRIBUTING.md

Important Files Changed

Filename Overview
composer.json Raises the PHP minimum to 8.4 and upgrades utopia-php/domains to 3.x.
composer.lock Refreshes the resolved dependency graph for domains 3.x, cache 4.x, pools 2.x, and telemetry 0.4.x.
.github/workflows/test.yml Aligns the test matrix with the new PHP minimum by testing PHP 8.4, 8.5, and nightly.

Reviews (2): Last reviewed commit: "ci: test on PHP 8.4 and 8.5" | Re-trigger Greptile

Comment thread composer.json
@@ -25,9 +25,9 @@
"import:stats": "php import.php stats"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Documented PHP minimum is stale

The package now requires PHP 8.4, while README.md and CONTRIBUTING.md still advertise PHP 8.0 or later. Users following those requirements on PHP 8.0–8.3 receive a Composer platform conflict, so the installation and contributor documentation should be updated with this requirement bump.

Prompt To Fix With AI
This is a comment left during a code review.
Path: composer.json
Line: 25

Comment:
**Documented PHP minimum is stale**

The package now requires PHP 8.4, while README.md and CONTRIBUTING.md still advertise PHP 8.0 or later. Users following those requirements on PHP 8.0–8.3 receive a Composer platform conflict, so the installation and contributor documentation should be updated with this requirement bump.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Fix in Claude Code Fix in Codex

Comment thread composer.json
@@ -25,9 +25,9 @@
"import:stats": "php import.php stats"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 CI targets unsupported PHP versions

The package now requires PHP 8.4, but the test matrix still runs PHP 8.1, 8.2, 8.3, and nightly while bypassing platform checks with --ignore-platform-reqs. This spends most test coverage on unsupported runtimes and does not explicitly validate the newly supported minimum, so the matrix should be aligned with PHP 8.4.

Prompt To Fix With AI
This is a comment left during a code review.
Path: composer.json
Line: 25

Comment:
**CI targets unsupported PHP versions**

The package now requires PHP 8.4, but the test matrix still runs PHP 8.1, 8.2, 8.3, and nightly while bypassing platform checks with `--ignore-platform-reqs`. This spends most test coverage on unsupported runtimes and does not explicitly validate the newly supported minimum, so the matrix should be aligned with PHP 8.4.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Fix in Claude Code Fix in Codex

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@loks0n
loks0n merged commit ae7baeb into main Jul 31, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant