Skip to content

build(deploy): add Makefile target and go.mod/go.sum build triggers #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Inuth0603 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

build(deploy): add Makefile target and go.mod/go.sum build triggers #1170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
434bfb3
ci(deploy): rebuild urunc-deploy on go.mod/go.sum changes
Inuth0603 Oct 27, 2026
e7bcd65
build: add Makefile target for the urunc-deploy image
Inuth0603 Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/build-trigger.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ on:
- 'internal/**'
- 'Makefile'
- 'VERSION'
- 'go.mod'
- 'go.sum'
workflow_dispatch:

concurrency:
Expand Down
17 changes: 17 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,10 @@ LINT_CNTR_CMD ?= golangci-lint run -v --timeout=5m
#? DOCS_CNTR_IMG The mkdocs image to use (default: harbor.nbfc.io/nubificus/urunc/mkdocs:test)
DOCS_CNTR_IMG ?= harbor.nbfc.io/nubificus/urunc/mkdocs:latest

#? URUNC_DEPLOY_IMG Name and tag of the urunc-deploy image (default: urunc-deploy:latest)
URUNC_DEPLOY_IMG ?= urunc-deploy:latest
URUNC_DEPLOY_DOCKERFILE := $(CURDIR)/deployment/urunc-deploy/Dockerfile

# Install dependencies variables
#
# If we have already built either static or dynamic version of urunc
Expand Down Expand Up @@ -232,6 +236,19 @@ docs:
docs_container:
$(CNTR_TOOL) $(CNTR_OPTS) -p 8000:8000 -v $${PWD}:/docs $(DOCS_CNTR_IMG)

# Deployment targets
#
# The urunc-deploy image must be built from the repository root and needs
# COMMIT as a build-arg, otherwise the embedded version has no commit.
## urunc_deploy Build the urunc-deploy container image for host arch.
.PHONY: urunc_deploy
urunc_deploy:
$(CNTR_TOOL) build \
--build-arg COMMIT=$(COMMIT) \
-f $(URUNC_DEPLOY_DOCKERFILE) \
-t $(URUNC_DEPLOY_IMG) \
$(CURDIR)

# Testing targets
## test Run all tests
.PHONY: test
Expand Down