Repository navigation
Conversation
Dependency updates change the urunc binary shipped in the urunc-deploy image, but the build trigger ignored go.mod and go.sum. Add them to the push paths so the image is rebuilt when dependencies change. Signed-off-by: Divyam Agarwal <iitdivyamagarwal@gmail.com>
Add a urunc_deploy target that builds the urunc-deploy image from the repository root and passes COMMIT as a build-arg. This avoids local builds that embed an empty commit in the urunc version string. Signed-off-by: Divyam Agarwal <iitdivyamagarwal@gmail.com>
✅ Deploy Preview for urunc canceled.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the
urunc-deploybuild workflow and add a Makefile target as follow-ups to #1102.Changes
go.modandgo.sumto the paths in.github/workflows/build-trigger.ymlso dependency changes trigger an image rebuild.urunc_deploytarget andURUNC_DEPLOY_IMGvariable to the Makefile to build the image from the repository root, passingCOMMITas a build arg.Related issues
Refs #1096
How was this tested?
make urunc_deploylocally onx86_64with Docker and checked thaturunc --versionshows the commit.make helpdisplays the new target andURUNC_DEPLOY_IMGvariable.LLM usage
Google Gemini (via Antigravity) assisted with drafting the Makefile target and commit formatting. I reviewed and tested the changes locally.
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).