fix(tutor): let serial-output be learned without an int variable - #4
Merged
Merged
Conversation
The Concept serial-output required variable-values, whose questions apply only when the sketch uses int. On sketches that print via Serial but have no int (16 of 35 Examples), serial-output could therefore never be selected: variables-and-serial was activated but unresolved from the first turn, and UnoSim blocked the Topic-driven Tutor with content-exhausted for the whole session. Serial output does not depend on an int: the Concept's objective, indicator, misconception, scaffold and both questions require only a Serial print call. The prerequisite is removed; activation, Concepts, questions and mastery stay unchanged, and preferredOrder still teaches variable-values first where the sketch has an int. The manifest hash of the Topic is updated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
variables-and-serialis activated by anySerial.print*call. Its Conceptserial-outputrequiredvariable-values, and all questions ofvariable-valuesapply only to sketches that useint.On sketches that print via Serial but have no
int, three things followed:serial-outputcould never be selected;content-exhaustedfor the whole session (LearningQuestions SSOT 2.3).This affected 16 of 35 Examples:
it01-02-konstante,it02-03-boolesche-operatoren,it02-04-bitoperatoren,it03-01-serielle-ausgabe,it03-02-serielles-zeichen-einlesen,it03-05-millis(afterlong-values),it05-03-switch,it06-01-while,it06-02-do-while,it06-03-for,it06-04-verschachtelte-schleifen,it07-01-funktion-ohne-rueckgabe,it08-01-struct,it08-02-array-aus-structs,it08-03-struct-als-parameter,it08-04-funktion-auslagern.The existing quality gate did not see it, because it only checks Topics that a quality case expects.
Change
serial-output.prerequisites: [variable-values]→[], plus the Topic's SHA-256 intutor/manifest.yaml. Nothing else changes.Why this is the right fix and not a test workaround:
concept,transfer) require onlyserial-call: print; none mentions anint.preferredOrder: [variable-values, serial-output]still teachesvariable-valuesfirst wherever the sketch has anint.Evidence
All checks are deterministic: the real UnoSim
TutorService,CurriculumTutorAdapter, matcher and planner, with a fake provider standing in for the model. No provider calls.2ac716f)it06-03-for(strong learner)serial-output-concept→serial-output-transfer→ masteryit03-05-millislong-valuesmasterylong-valuesandvariables-and-serialboth masteredit01-01-variable-speichernaaa52fad, this repo's CI)unmasterable-example-activationKnown and out of scope: after mastery, post-mastery content is thin. Serial-only Examples have no DEEPEN question left and continue with the blocked free fallback. That is legitimate per the runtime contract and a separate authoring task (more DEEPEN questions, Topic v2 extensions).
Follow-up
Once the UnoSim gate PR is merged, bump
.unosim-compatible-commitso that this repository's CI enforces the catalog-wide check.🤖 Generated with Claude Code