fix: reject disconnected via route transitions - #232
Open
seveibar wants to merge 1 commit into
Open
Conversation
seveibar
force-pushed
the
fix/reject-disconnected-via-transitions
branch
from
August 22, 2026 07:26
499d4ce to
34b2439
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pcb_tracevia route point to be immediately bracketed by wire pointsWhy
checkTracesAreContiguouspreviously inspected a via only when both neighboring route points were already wires. A malformed route such aswire -> via -> via -> wiretherefore skipped validation entirely, even though no copper segment connects the two vias. The same blind spot allowed edge vias and layer-mismatched transitions through the shared routing checks.This was reproduced while auditing the manufacturing output in
tscircuit/quick-configure: an initially prepared USB-C fan-in path contained consecutive vias and would have exported without the intended bottom-layer copper.The layer check treats
from_layer/to_layeras the physical plated span. For example, atop-to-bottomvia may legitimately connect adjacenttopandinner1wire points.Validation
bun test— 184 pass, 0 failbunx tsc --noEmitbun run build