fix: connect manual pcbPath vias on both layers - #3373
Open
seveibar wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pcbPathviafromLayerdisagrees with the current path layer before malformed copper is emittedWhy
A
pcbPathcontaining consecutive vias previously serialized aswire -> via -> via -> wire. There was no wire on the layer between those vias, so Gerber output omitted the intended connecting copper while the source still looked fully specified.This was reproduced while fixing the reviewed USB-C fan-in in
tscircuit/quick-configure. The shared validation companion, tscircuit/checks#232, makes malformed raw Circuit JSON fail closed; this PR fixes the producing path in core.Compatibility
Existing paths that already place ordinary points at the via coordinates keep the same effective route. Exact same-position/same-layer wire points are deduplicated, while distinct corners and layer changes are preserved.
Validation
bun test --timeout 9999999— 1,432 pass, 40 skip, 0 failpcbPathsuite — 4 pass, 0 failbunx tsc --noEmitbun run build