Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeated script decisions retain dead native strings after
restart(), eventually exhausting the VM's bounded string storage. Reclaim them inside Bassy while preserving globals, arrays, host data, and cached literals. Scratch space is reserved during runtime initialization and included in the memory budget.Adds
withStringfor scoped, validated access to a string's bytes without allocating a temporary Nim string. Hosts must not mutate or restart the VM inside that block. String Values retained by host code must be fetched again after a restart because compaction remaps their handles.This lets Polyworld remove its private-access string-memory adapter and use the regular VM API for game-owned mailboxes.
Validation:
nim checkand the full debug, release, and C++ release test suites pass. The original determinism digests are unchanged. Tests cover 1,000 restarts, persistent globals/arrays/host data, borrowed substrings, empty strings, and stale handle rejection.