Repository navigation
fix(api): match API Blueprint port types to the live API - #1082
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Author
|
@codex review |
kevincador
force-pushed
the
fix/api-apib-port-response-shapes
branch
from
November 19, 2026 07:50
43eaa72 to
3a75f41
Compare
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
StefanFriptu
force-pushed
the
fix/api-apib-port-response-shapes
branch
from
November 19, 2026 12:37
3a75f41 to
4f72119
Compare
Collaborator
|
Folded two fixups into the matching commits:
|
StefanFriptu
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects routes from the API Blueprint port (732a903) whose request or response types do not match what the live API sends. Each fix is its own commit, checked against the live route's behavior. No routes are added or removed.
These are breaking type changes for consumers of these routes, so they ship separately from the
PUT /sync/watchlistfix (#1081).Fixes
GET /comments/{trending,recent,updates}{type, comment, movie?, show?, season?, episode?, list?}(commentActivityResponseSchema)GET /comments/:id/itemz.unionof bare media objects{type, <media key>?}object (commentItemResponseSchema), no union perschemas.mdGET /shows/:id/certifications{certification, country}(showCertificationEntryResponseSchema)POST /users/hidden/:section+/removerouteswatched_at, episodes),deleted.{movies, episodes},added.seasonhiddenItemsRequestSchema(hidden_at, movies, shows, seasons, users);deleted/addedwithmovies, shows, seasons, usersGET /users/hidden/:section{hidden_at, type, movie?, show?, season?, user?}(hiddenItemResponseSchema)GET /users/:id/notes/:type{attached_to, type, <media>?, note}(userNoteResponseSchema)POST /notesbodyitemkeyattached_to,notes,privacy,spoilerKnown gaps, not in this PR
GET /users/:id/notes/:type?extended=minreturns a smaller shape than the default one typed here.noteResponseSchemaand thePUT /notes/:idbody still carry an unuseditemfield.comment_type/typeare optional on the live comment activity routes but required path params here.getanddroppedhidden routes still usehiddenShowResponseSchema.Checks
bun run check,bun run testbun run lint(same warnings as master),bun run format:checkbun run openapi:validatebun run publish:check