Repository navigation
str: add missing note attachment and comment item fields - #363
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trakt's API contract (trakt/trakt-api#1082, merged 2026-11-19) describes two response shapes with more fields than our types had.
Added
str.AttachedTohasWatchedAt,CollectedAt,RatedAtandRating.str.CommentMediaItemhasPerson,CommentandUser.Fixed
users -a noteskeeps the date and rating of the history, collection or rating entry a note is attached to. Before,attached_toheld onlytypeandid.comments -a itemkeeps the person, comment or user a comment belongs to. Before, onlytypewas exported.The new
AttachedTofields are nil when a note is sent, so thePOST /notesrequest body does not change. The rest of #1082 (comment activity, show certifications, hidden items, notes create body) already matches our types.Tests: the encode/decode round-trip tests in
str/fail without the fix.Live check by the maintainer on 2026-11-19:
users -a notesexported 3 rating notes, each withrated_atandrating.comments -a itemon a list comment still works. The history and collection fields and the person, comment and user items are covered by the mock tests only (no such data on the account, no CLI route lists them).AI: Claude Code compared the contract with the types and wrote the code, tests and changelog entries.