Skip to content

fix(api): type the update watchlist body as watchlist settings - #1081

Merged
StefanFriptu merged 1 commit into
masterfrom
fix/api-watchlist-update-contract
Nov 18, 2026
Merged

StefanFriptu merged 1 commit into
masterfrom
fix/api-watchlist-update-contract

Conversation

@kevincador

Copy link
Copy Markdown
Contributor

Fixes #1079

PUT /sync/watchlist updates the watchlist settings, not its items. The contract had copied the body and response from POST /sync/watchlist, so it typed an items body (movies / shows / seasons / episodes) and an added / existing / not_found response.

This matches the contract to the live route and the original API Blueprint docs:

  • Body: description, sort_by, sort_how (all optional, send 1 or more).
  • Response 200: the watchlist list object (listResponseSchema, same as PUT /users/:id/lists/:list_id).
  • Description: restored the "send 1 or more parameters" text and the JSON POST Data table.

Per-item notes stay on PUT /sync/watchlist/:list_item_id, which is unchanged.

Checks

  • bun run check, bun run test
  • bun run lint, bun run format:check
  • bun run openapi:validate
  • bun run publish:check

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T10:52:29.155072Z 342ba00 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

PUT /sync/watchlist updates the watchlist description and default sort and returns the watchlist list object. The contract had the items body and the add response from POST /sync/watchlist.
@StefanFriptu
StefanFriptu force-pushed the fix/api-watchlist-update-contract branch from 342ba00 to b6f3e0d Compare November 18, 2026 16:08
@StefanFriptu
StefanFriptu merged commit d1b4fa6 into master Nov 18, 2026
9 checks passed
@StefanFriptu
StefanFriptu deleted the fix/api-watchlist-update-contract branch November 18, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PUT /sync/watchlist is typed with an items body, but the live route updates the watchlist settings

2 participants