Conversation
…irectly-set env.HTTP_PROXY #236 excluded the proxy-owned keys (HTTP_PROXY/HTTPS_PROXY/NO_PROXY/… plus the HTTP_PROXY_* inputs) from jobs-manager's generic .Values.env passthrough UNCONDITIONALLY, so tracebloc.proxyEnv would be the sole source. But proxyEnv only emits when HTTP_PROXY_HOST is set — when it is UNSET, proxyEnv renders nothing AND the passthrough now drops a directly-set env.HTTP_PROXY (a full proxy URL, the pre-1.6.0 way to configure a corporate proxy). Net effect: clusters that set the raw HTTP_PROXY value instead of HTTP_PROXY_HOST lose backend/registry egress behind their corporate proxy on upgrade to 1.6.0 — an upgrade regression flagged by Cursor Bugbot on release PR #235. Gate the exclusion on proxyEnv being active: build $proxyKeys empty and only populate it when .Values.env.HTTP_PROXY_HOST is set (mirrors proxyEnv's own gate). When unset, the list stays empty so the passthrough emits directly-set proxy vars verbatim — prior behavior preserved. When set, the exclusion holds exactly as in #236 (proxyEnv authoritative; a stray direct HTTP_PROXY dropped). Adds a proxy_env_test regression: a direct env.HTTP_PROXY + NO_PROXY with no HTTP_PROXY_HOST passes through on both jobs-manager containers. Confirmed the test fails (4 asserts) against the unconditional #236 template. Validation: helm unittest 196 pass (+1 regression); lint clean; 4-platform render (aks/bm/eks/oc) clean; render-verified both scenarios (direct HTTP_PROXY survives when host unset; proxyEnv authoritative and stray direct value dropped when host set). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…on lockstep The 1.6.0 chart bump (#231) moved Chart.yaml `version` 1.5.1 → 1.6.0 but left `appVersion` at "1.5.1" — every prior release (1.1.0 … 1.5.1) bumped the two in lockstep. tracebloc.labels emits `app.kubernetes.io/version` from .Chart.AppVersion, so a 1.6.0 chart labelled every resource (and reported to cluster info, which reads that standard label) as app version 1.5.1 while `helm.sh/chart` correctly said client-1.6.0 — two disagreeing version signals. Restore lockstep so the published 1.6.0 carries the right app version from the start (no stale-label 1.6.1 follow-up). No functional/workload change; helm unittest 196 pass, lint clean, render shows both labels at 1.6.0. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Ship this PR's fixes as a 1.6.1 fast-follow (per #238) rather than folding into the still-unpublished 1.6.0: the proxy-key exclusion gate (#238) and the appVersion lockstep correction. Bumps both version and appVersion together so they stay in lockstep (the 1.6.0 bump's miss is what stranded appVersion at 1.5.1 in the first place); supersedes the intermediate appVersion=1.6.0 from the previous commit. helm unittest 196 pass; lint clean; render shows both labels (app version + helm.sh/chart) at 1.6.1. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
release: client chart 1.6.1 — proxy-key exclusion gate (#238) + appVersion lockstep
saadqbal
added
the
skip-fr-gate
shujaatTracebloc
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync
develop→mainto cut client chart v1.6.1 (fast-follow to 1.6.0). Tracks #240.developis ahead ofmainby the #239 fixes:HTTP_PROXY_HOST(fixes a 1.6.0 upgrade regression for raw-HTTP_PROXYproxy clusters).version/appVersionlockstep restored — both → 1.6.1 (1.6.0 strandedappVersionat 1.5.1).Delta over 1.6.0 is template-only and a no-op for any non-proxy cluster (entire known fleet). CI gate green on #239 (lint, render×4, schema×4, 196 unit, drift, multi-arch, Bugbot).
skip-fr-gateapplied per the v1.6.0 sync (#235) precedent for release-promotion PRs.After merge: publishing GitHub Release v1.6.1 triggers
release-helm-chart.yaml→ packages client + ingestor from the tag → gh-pages index.yaml. NOTE: this flips fleet-wide auto-upgrade — auto-upgrade-ON clients converge 1.6.0 → 1.6.1 at their next :23 cronjob.🤖 Generated with Claude Code
Note
Low Risk
Template-only change scoped to jobs-manager proxy env wiring; no-op for the known non-proxy fleet and restores pre-1.6.0 behavior for direct HTTP_PROXY setups.
Overview
Cuts client Helm chart v1.6.1 with
versionandappVersionboth set to 1.6.1 (fixing 1.6.0’s strandedappVersion).#238 fix in
jobs-manager-deployment: proxy-related env keys are only excluded from the generic.Values.envpassthrough whenHTTP_PROXY_HOSTis set (i.e. whentracebloc.proxyEnvis active). Clusters that still configure a corporate proxy via rawenv.HTTP_PROXY/NO_PROXYkeep those values on upgrade instead of having them stripped.Adds a Helm unit test that asserts direct
HTTP_PROXYandNO_PROXYsurvive on both jobs-manager containers whenHTTP_PROXY_HOSTis unset. No behavior change for clusters without proxy or those usingHTTP_PROXY_HOST.Reviewed by Cursor Bugbot for commit 7241c0f. Bugbot is set up for automated code reviews on this repo. Configure here.