Sync develop → main for v1.7.0 chart release (§8.2 egress gateway, inert)#252
Merged
Conversation
feat(egress-proxy): training-pod egress lockdown — squid gateway, gated rollout (client-runtime#102)
aptracebloc
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes chart 1.7.0 (develop → main) — the §8.2 training-pod egress gateway (tracebloc/client-runtime#102). Snapshot of
developat2fb5b8f.What ships — and it ships INERT
A new in-cluster squid egress gateway (
egressProxy.*) + the lockdown flags, all default-off:egressProxy.enabled: true→ the gateway Deployment/Service/ConfigMap deploy (idle ~50m/64Mi pod; nothing routes to it).egressProxy.routeWorkloads: false→ jobs-manager does not injectHTTPS_PROXY; training pods unchanged.networkPolicy.training.allowExternalHttps: true→ the0.0.0.0/0:443egress rule is kept; no lockdown.Net effect of this release on every fleet: a new idle gateway pod and zero change to training-pod egress. The actual lockdown is a separate, per-fleet flag flip (below), not enabled here.
Validation
helm unittest212/212,pytest201/201, and the newupgrade-e2eCI gate green (installs the last published chart, upgrades through--reuse-values+--reset-then-reuse-values, confirms nil-guards hold + the flip persists).--reset-then-reuse-valuescarries the new defaults in inert; new keys nil-guarded against--reuse-values; the training netpol's podSelector is pinned so the lockdown can never catch the auto-upgrade/image-refresh cronjobs.Rollout posture (do NOT flip on merge)
This release is Phase 1 — ship the mechanism inert. Enabling the lockdown is a staged, per-fleet action gated on:
enableNetworkPolicy=true; without it the lockdown is silently cosmetic).routeWorkloadson a cluster with live training, then a rollback, disrupts in-flight pods — observed during dev validation).Cross-repo dependency for the flip: before setting
routeWorkloads=trueon a fleet, that fleet'sjobs-managerimage must include client-runtime#103 (theEGRESS_PROXY_URL→HTTPS_PROXYinjection). Inert-on-upgrade is unaffected; this only matters at flip time.Post-merge (per release runbook)
Tag + publish the GitHub Release on
main→ release workflow packages from the tag → gh-pages → fleets auto-upgrade at :23 (gateway lands inert).Refs tracebloc/client-runtime#102.
skip-fr-gateper release convention (matches #241/#235).Note
Medium Risk
Changes training NetworkPolicy semantics and fleet upgrade paths; defaults keep direct HTTPS and routing off, but misconfigured per-fleet lockdown or non-enforcing CNI could break training egress.
Overview
Chart 1.7.0 adds the §8.2 in-cluster squid egress gateway (
egressProxy) and the knobs to tighten training-pod egress without changing behavior on upgrade by default.New Helm resources deploy squid (ConfigMap/Deployment/Service) with an FQDN allowlist, PSA-hardened pod spec, and optional upstream
cache_peerwhenenv.HTTP_PROXY_HOSTis set.egressProxy.routeWorkloadsdefaults to false, so jobs-manager does not setEGRESS_PROXY_URLand training traffic is unchanged; when enabled, jobs-manager points training pods ategress-proxy-service. The training NetworkPolicy gates the broad0.0.0.0/0:443rule onnetworkPolicy.training.allowExternalHttps(default true, nil-safe for--reuse-values) and adds an explicit egress rule to the gateway pod when the proxy is enabled.values.yaml, values.schema.json, and egress_proxy_test.yaml document and lock in nil-guards, fail-closed allowlisting, and netpol/job-manager wiring. docs/SECURITY.md describes the gated rollout and updated interim risk for Service Bus.
CI adds
scripts/tests/e2e-auto-upgrade.shand anupgrade-e2eHelm job: install last published chart on k3d, exercise--reuse-valuesand--reset-then-reuse-values, assert lockdown stays off until flipped, then that operator lockdown settings survive the next auto-upgrade path. Shellcheck workflows include the new script.Reviewed by Cursor Bugbot for commit 2fb5b8f. Bugbot is set up for automated code reviews on this repo. Configure here.