Repository navigation
builder: give the ground-plan bridge budget the owner's 8 KiB margin - #3486
Conversation
The budget was the CI size rounded up to the next whole KiB: 65 B gzipped and 674 B raw of headroom on a toolchain that follows stable. The guard now states the recorded CI size and the owner's margin apart, and prints both parts with the change against the recorded size. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
Review of #3486 (head 7ec28df, base ground-plan)Verdict: MERGE AFTER FIXES. The fix is one sentence of text (F1). The code is correct. Checks
FindingsF1 (should fix). No rule says when the recorded size changes.
F2 (minor, existing text). The comment
Not checked
Generated by Claude Code |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
What
The size guard of the ground-plan bridge (
builder/wasm/wasm_size_guard.py) gets a budget in two parts:The guard prints the measured size, the budget, and the two parts of the budget, with the change against the recorded size. A reviewer sees growth inside the margin.
A pull request that changes the code of the bridge records its own CI size in the guard. The margin is only for toolchain and dependency noise.
Why
The old budget was the CI size rounded up to the next whole KiB. It had 65 B gzipped and 674 B raw of headroom.
rust-toolchain.tomlfollowsstable. The next Rust release or a small dependency update can move the size by a few kilobytes. That fails unrelated pull requests. The owner chose a margin of 8 KiB. A pinned toolchain was the other option; the owner did not choose it. Real growth past the margin still fails.Figures
The other budgeted bridge does not change. Its headroom on the CI run of #3481 (
wasm-bridges, stable 1.100.0):The test device (
flat-device) has no budget. No other bridge has headroom under 1 KiB.Checks
python3 -m py_compile builder/wasm/wasm_size_guard.py.--module ground-plan --pkg …): it prints both parts of each budget and exits 0.wasm-bridgesruns the guard on this head.obc suites checkis not necessary: no test sources, suite commands or workflows change.Public docs: unchanged.
Mode: change #3105
Requirements: none
🤖 Generated with Claude Code