Draft: feat(donation-appeal): Create the logic to display the donation appeal - #11583
dani-zilla wants to merge 9 commits into
Conversation
…he logic for the first displayed appeal to prepare for a second.
…splay the new funding reminder
…ell as the logic changes for the first appeal.
|
✅ Validation Passed: All report and feature-flag labels are correctly set. |
…ng, was launching the check between activities switching, now waits to do check after resume. Fixed bug with reading null values from datastore
|
Fixed two issues, but still seems to fail to launch the donation appeal fragment, despite passing all the checks. Looking into this currently as well |
c143ba9 to
8ea0305
Compare
264ade0 to
3ba2b5c
Compare
|
There's an issue in main that this PR needs to address. While calling the initialization in the We need to ensure we're only calling the lifecycle observer for this once. One way to do that will be moving it entirely to the Currently, this is the only reason the second reminder does not display, and we can fix it once we fix this. |
…ity observer to not register multiple times.
5da78fe to
de55e82
Compare
Contribution Summary
Closes: #11547
Description
This introduces the logic and tests that define when we display a second donation appeal after the first one.
It currently uses the same fragment and UI as the original, as the UI will be completed in another ticket.
This also introduces tests for the second funding reminder, as well as adding new tests for displaying the first funding reminder. We don't want these to overlap.
Screen Shots
Existing UI. Updating this is out of scope for this ticket:
AI Disclosure
Select one of the following (mandatory)
Contribution Checklist
gradlew spotlessCheckto check andgradlew spotlessApplyto format your source code; will be checked by CI).gradlew testDebugUnitTest; will be checked by CI).Testing Instructions
To test this, you'll have to go into
FundingReminderContract.ktAdjustFUNDING_REMINDER_DELAY_MILLISto be under1000LDo the same forFUNDING_REMINDER_MIN_ACTIVITY_MILLISDon't do 0L if you'd like to test the delay better. You can set theFUNDING_REMINDER_DELAY_MILLISto30000L, for example, to test that the alerts only show after 30 second has passed. You can then, after the amount of waiting required, open the account drawer, select settings, then go back to the message list. Now select a message and press back. It should appear as the message list appears. This is reflective of the current implementation, and changing it may be a part of a future ticket, but matching the behavior of the existing code is the current goal. You will have to clear app storage between tests.