The donation appeal currently doesn't display for most if not all of our users. This was due to a race condition. This was initially fixed in this PR, but later pulled out and submitted as an individual fix by someone else.
However, this was a quick fix. The real issue is that while there was a race condition with the activity observer, we also are creating multiple instances of the observer. This makes it impossible to display the next appeal, as he activity counter is being reset. While it might help track a single appeal, it may not work if the activity isn't saved before it's reset again, and resetting it could reset it in the database, as there's no protection to ensure this value can only increment.
The fix for this is multi-fold. We could ensure there's only one instance of the activity observer that is resetting this value. We could also make sure to move this value out of the long-deprecated k9.kt class and into a data store, where we could apply better logic to it, including that the number should only ever be able to increment up.
This is a vital fix that is broken in production, broken in the latest uplift fix, and holding this project back.
The donation appeal currently doesn't display for most if not all of our users. This was due to a race condition. This was initially fixed in this PR, but later pulled out and submitted as an individual fix by someone else.
However, this was a quick fix. The real issue is that while there was a race condition with the activity observer, we also are creating multiple instances of the observer. This makes it impossible to display the next appeal, as he activity counter is being reset. While it might help track a single appeal, it may not work if the activity isn't saved before it's reset again, and resetting it could reset it in the database, as there's no protection to ensure this value can only increment.
The fix for this is multi-fold. We could ensure there's only one instance of the activity observer that is resetting this value. We could also make sure to move this value out of the long-deprecated k9.kt class and into a data store, where we could apply better logic to it, including that the number should only ever be able to increment up.
This is a vital fix that is broken in production, broken in the latest uplift fix, and holding this project back.