Support nippy >= 3.7 - #483
Merged
Merged
Conversation
Fixes #482. nippy 3.7.0 removed the private -freeze-without-meta!. Use the public freeze-to-out! instead, which exists in both old and new nippy and emits identical bytes here since neither dataset->data nor column->data carries metadata. Needs the matching dtype-next fix to tech.v3.datatype.nippy to take effect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #482.
nippy 3.7.0 removed the private
-freeze-without-meta!. Swaps both call sites for the publicfreeze-to-out!, per Peter's guidance.Same
[^DataOutput dout x]signature in 3.6 and 3.9, so no dep bump. Metadata is written only(when-let [m (not-empty (meta x))], anddataset->data/column->databuild literal maps with none — old and new code on 3.6 produce byte-identical output.Verified on 3.6.0 and 3.9.0-RC1:
stocks-v5.nippy/example-genres.nippyfixtures, gzip roundtrip,put-nippy!/get-nippy, column freeze/thaw. New code on 3.9 thaws a file written by old code on 3.6.Needs cnuernber/dtype-next#146 released first —
tech.v3.datatype.nippyhas the same breakage and is required by this ns, so it fails to compile before this file is reached.