Support nippy >= 3.7 - #146
Merged
Merged
Conversation
nippy 3.7.0 removed the private -freeze-without-meta!. Use the public freeze-to-out! instead, which exists in both old and new nippy and emits identical bytes here since none of the frozen maps carry metadata.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tech.v3.datatype.nippyfails to compile against nippy >= 3.7, which removed the private-freeze-without-meta!:Swaps the 5 call sites for the public
freeze-to-out!, per Peter's guidance.Same
[^DataOutput dout x]signature in 3.6 and 3.9, so no dep bump. Metadata is written only(when-let [m (not-empty (meta x))], andbuffer->data/tensor->databuild literal maps with none — old and new code on 3.6 produce byte-identical output.Verified buffer and tensor roundtrips on 3.6.0 and 3.9.0-RC1.
Companion to techascent/tech.ml.dataset#483.