Repository navigation
feat(outprint): add packages for own templates and configurations - #36
Merged
Merged
Conversation
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Lets the chart use your own Outprint Template and Configuration packages without building an image (chart 1.2.0).
packages.git: a Job (install, and on a change ofurl/ref/commit/path) and a CronJob (interval) resolveref(tag, branch or commit) to a commit. On a change they clone it (Git LFS included), runoutprint validateagainst the service configuration, switch/packages/currentover only if it passes, then restart Gateway and Worker. A broken revision never replaces a working one.commitis an optional integrity check.packages.image: mounts an OCI image as a Kubernetes image volume (Kubernetes 1.35+).packages.existingClaim: mounts a PVC you maintain.gateway.extraVolumes/extraVolumeMountsand the same underworker.OUTPRINT_TEMPLATES_ROOT/OUTPRINT_CONFIGURATIONS_ROOT; the git source adds an initContainer that waits for the first sync.Only the sync Job has network access; the Worker NetworkPolicy is unchanged. The Job's ServiceAccount may only
get/patchthe Gateway and Worker Deployments.Docs: taskmedia/outprint#162 (Install > Run Outprint > Your own Templates and Configurations).
Notes
git-lfsandopenssh-clientwithapkat start (alpine/k8shas neither). If the mirror is down the Job fails and the active revision stays.Test plan
helm lintandct lintpasshelm templateforgit,image,existingClaim, none, and two sources (fails with a clear message)taskmedia/outprint@v1.0.1: ref resolution, LFS-capable clone, validate (passes, and fails on a Binding to a missing package), activate,commitmismatch