Repository navigation
feat(outprint): allow several git sources for packages - #37
Merged
Merged
Conversation
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #36 (chart 1.3.0). Outprint reads one
templatesRootand oneconfigurationsRoot, so packages from several repositories have to be merged before start.packages.sourcesdoes that:packages.gitstays and counts as a source nameddefault, so existing values keep working.interval,image,resources,persistenceandkeepRevisionsunderpackages.gitapply to all sources.templates/<name>and/orconfigurations/<name>(at least one). The sync resolves everyref, checks every source out (Git LFS included), merges the packages into one revision, validates it withoutprint validateand switches over as a whole.name=commitpairs for several. After the upgrade the running revision is re-synced once.commitmismatch of any source.sshKeySecret, mounted at/ssh/<name>).^[a-z0-9][a-z0-9-]*$and be unique; a missinggit.url, a duplicate name, or mixing withimage/existingClaimfails athelm templatewith a clear message.Test plan
helm lintandct lintpasshelm template: shorthand only, sources only, shorthand plus sources, duplicate name, bad name, missing URL, mixed kinds