Repository navigation
ci(release): publish @systemfsoftware/drizzle-pg-extras through trusted publishing - #5
Merged
Merged
Conversation
…orkflow - Scoped package name, workspace-member layout, flake, release caller, and the enrollment order for the owner.
…e/drizzle-pg-extras - The release tooling lists workspace members and drops the root package, so the package moves to packages/drizzle-pg-extras under a private root. - Rename to @systemfsoftware/drizzle-pg-extras; the CLI bin stays drizzle-pg-extras and runtime identifiers are unchanged. - Pin pnpm 12.9.0, the version the flake provides, and regenerate the lockfile with it. - Derive VERSION from the package manifest so a release edits no source file. - Run attw, publint and the rc install inside the member; let ci.yml be dispatched.
- packages.<system>.workspace-tarballs lists the scoped package; the dev shell provides Node 24 and pnpm 12.
… publishing - Caller pins the shared release workflow by commit SHA, with ci.yml dispatched on the release PR branch and npm-publish on. - release.jsonc and a change-intent directory supply what the workflow reads from a caller.
- pnpm 12.9, the version the flake pins, resolves the `rc` tag to 1.0.0-rc.5-ab785fc, an older snapshot build that fails the drizzle-kit snapshot-chain tests; pnpm 12.21 resolved 1.0.0-rc.5. - Installing the exact version keeps the job on the release candidate the suite was written against.
- The approval gate requires the R0 line verbatim as the first entry under Requirements; no other text changed.
- The approval gate requires the standard R0 wording verbatim; the interim issue-reference sentence is dropped rather than moved, because the issue id and person name must not appear in this public repository.
|
@Mergifyio queue |
This was referenced Nov 20, 2026
❌ Left the queue ·
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Once this merges and the owner enrolls trusted publishing, every push to
maincan publish the package to npm as@systemfsoftware/drizzle-pg-extrasthrough the shared release workflow's OIDC trusted publishing, with no npm token. The unscoped namedrizzle-pg-extrasbelongs to the upstream author, so the scoped name is the one this repository can publish. The CLI is stilldrizzle-pg-extras.Owner steps: merge first, then enroll
Merge this PR first, so
release.ymlexists onmain. Then run:npm-trustreserves@systemfsoftware/drizzle-pg-extraswith0.0.0-bootstrap.0, then trustssystemfsoftware/drizzle-pg-extrasand the caller workflow file it finds,release.yml. The npm session needs publish rights in the@systemfsoftwarescope (inferred, not observed).The first
Releaserun happens on the merge, before enrollment. It is expected to tag@systemfsoftware/drizzle-pg-extras@v0.6.0and create the GitHub Release, then fail atpublish, because npm does not yet trust the workflow. That is inferred from the release workflow's README and has not been observed. After enrolling, runReleaseonmain(Actions,workflow_dispatch) or re-run the failed job; it publishes 0.6.0 and waits until it installs.Why the package moved into
packages/drizzle-pg-extrasThe shared release tooling drops a package that sits at the workspace root: the member list skips the root row, and the flake's workspace reader cannot parse
.as an entry. A root-only package would get no version PRs, tags, GitHub Releases or change intents, so the root is now a private manifest and the package is its only member. Files moved withgit mv, so history follows them. The published surface (exports map, bin,files,engines, peers, licence) is unchanged.What else changed
pnpmis pinned to 12.9.0, the version the flake provides; the flake build fails on any other pin. The lockfile was regenerated with it, and no third-party package changed version.VERSIONnow comes from the package manifest, so a release PR editspackage.jsonandCHANGELOG.mdonly. The builtdist/carries the literal and does not read the manifest at runtime.release.ymlis the organisation's caller. It differs fromeffect-daemon's only in the pinned revision of the shared workflow (below).ci.ymlacceptsworkflow_dispatch, which the release workflow needs to run CI on the release PR branch, and runsattwandpublintinside the package. The drizzle 1.0 job installs exactly1.0.0-rc.5: under pnpm 12.9 therctag resolved to the older1.0.0-rc.5-ab785fcsnapshot, whose drizzle-kit fails the snapshot-chain tests (pnpm 12.21 resolved1.0.0-rc.5). Job names andchecks / checkare unchanged.release.jsonc,.changeset/and a flake (workspace-tarballs, dev shell with Node 24 and pnpm 12) are what the release workflow reads from a caller.Decisions for the owner
9615867c17489fb04be8bc74f568659d687df612, which five of the seven organisation libraries use.effect-daemonuses1e897828d917341fb7dd444c7bbd6cfa0998caa9, which adds a fix for a race where a run queued behind a release-PR merge reopens a release PR for versions that already shipped. Switching is a one-line change.README.md; the package README sits inpackages/drizzle-pg-extras.Follow-up
The plan's objective says every published version comes from the release workflow. The
0.0.0-bootstrap.0placeholder is published by hand during enrollment, so the objective wants rewording.Testing
Run in the package: typecheck, lint,
dprint check, the 64 unit tests, the build,attwandpublintall pass. The built CLI keeps its shebang and the builtVERSIONmatches the manifest. The flake evaluates:workspace-tarballslists the scoped package and the dev shell gives pnpm 12.9.0.Not run here, pending off-host:
VERSIONunit test was added, because the repository's test rules refuse tests that import fromsrc/.nix build .#workspace-tarballs, thennix build --rebuild .#workspace-tarballs, which also gives the cold-build time. Neither was run.planandbumpon the merged tree, then the first realReleaserun.