Repository navigation
ci: keep Mergify queue drafts from cancelling their own CI - #8
Merged
Merged
Conversation
- A queue draft fires several pull_request events in a row; each one cancelled the run in flight in the same concurrency group, so the aggregate saw every job cancelled and failed, and Mergify dequeued the pull request on that failure. - Queue-draft heads no longer cancel in-progress runs, matching the org's reusable CI.
- The review asked for the cause to live in the repo, not only in a PR body. - Solution entry: how queue-draft pull_request events cancelled in-flight runs, why the aggregate must keep failing on cancelled batches, and the concurrency invariant to keep.
There was a problem hiding this comment.
Reviewed at 0328fa1: the queue-draft exemption keeps every job required and fixes the self-cancelling queue CI. One P2 is a follow-up: the solutions doc says the queue worked end to end after the fix, but no queue run has happened yet. Correct that wording after the first queued merge proves it.
|
@Mergifyio queue |
☑️ This pull request is already mergedDetailsIts changes are already in its base branch. To merge other changes, open a new pull request with them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pull requests queued for merge were being dequeued with
CHECKS_FAILEDeven though every job on the queue branch had passed on its own. The queue's draft pull request fires severalpull_requestevents in a row while Mergify opens and annotates it. They all shared one concurrency group, so each new event cancelled the run still in flight, thechecks / checkaggregate reported those cancellations as a failure, and Mergify read that failure and dequeued the pull request.Queue-draft heads no longer cancel in-progress runs — the same rule the organisation's reusable CI uses. Regular pull requests keep the cancel-on-newer-push behavior, and the aggregate still requires every job to succeed; no check is weakened or skipped.
Evidence from the incident: on the queue branch, the aggregate failed with
RESULTS: cancelled cancelled cancelled cancelled, and the next run on the same branch, left uncancelled, went green.Related: #5 (the pull request the queue could not merge), #2 (where
checks / checklanded).Validation
dprint checkpasses (covers this file).actionlint(not installed) and the test suite — CI configuration only, and the assignment scoped checks to the format check.