Skip to content

chore: bump bitkit-core ldk-node to match android - #726

Merged
ovitrif merged 1 commit into
masterfrom
chore/725-bump-core-ldk
Sep 3, 2026
Merged

chore: bump bitkit-core ldk-node to match android#726
ovitrif merged 1 commit into
masterfrom
chore/725-bump-core-ldk

Conversation

@ovitrif

@ovitrif ovitrif commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Closes #725

This PR aligns iOS SPM pins with Android synonymdev/bitkit-android#1223.

  • Pins bitkit-core from 0.5.3 to 0.5.14.
  • Pins ldk-node from 0.7.0-rc.63 to 0.7.0-rc.66.
  • Updates watcher fixtures and production matches for the new nextUnusedExternalAddress field.

After this merges, #693 should drop its 0.5.10 pin and rebase onto 0.5.14.

Releases:

Preview

N/A — no user-visible changes.

QA Notes

Manual Tests

  • 1. Home → Receive: Savings and Spending tabs plus the receive QR render.
  • 2. regression: Home → background the app → foreground Bitkit: Home remains responsive and the node stays usable.
  • 3. Settings → Advanced → Dev Settings → LDK → Restart: Restart completes, then Receive still works.

Automated Checks

  • Unit tests modified: add nextUnusedExternalAddress to WatcherEvent.transactionsChanged fixtures in HwWalletManagerTests.swift, HwWalletManagerFundingTests.swift, and TrezorViewModelWatcherTests.swift.
  • Simulator Debug build passed.
  • Focused simulator tests: 73 passed (HwWalletManagerTests, HwWalletManagerFundingTests, TrezorViewModelWatcherTests).
  • Published xcframework SHA-256: bitkit-core 2e5d3a3e263d2de044c3d5b9a9ddcc789c8cf651b6bbd240fb7fe407b5e9be84; ldk-node 21ac13bfdc9fdd3099a688bd0053f8b14c74b5957943b2f09624886e65556a8e.
  • Package.resolved revisions: bitkit-core 890502f241e12305325cdd0f5e46b2752b9aedf4; ldk-node 190a17d966cf5a685444cfa17c3a419c290bf26c.

@ovitrif ovitrif self-assigned this Sep 3, 2026
@ovitrif
ovitrif requested a review from jvsena42 September 3, 2026 12:51
@ovitrif ovitrif added this to the 2.5.0 milestone Sep 3, 2026
@greptile-apps

greptile-apps Bot commented Sep 3, 2026

Copy link
Copy Markdown

Greptile Summary

Updates the exact Swift Package Manager pins for bitkit-core and ldk-node and adapts watcher-event handling to bitkit-core’s added address field.

  • Pins bitkit-core at 0.5.14 and ldk-node at 0.7.0-rc.66, with matching resolved revisions.
  • Updates both production transactionsChanged pattern matches for the additional nextUnusedExternalAddress value.
  • Updates hardware-wallet and Trezor watcher test fixtures to construct the expanded event.

Confidence Score: 5/5

The PR appears safe to merge, with no concrete blocking or non-blocking defect identified in the changed code.

The package pins and resolved revisions are internally consistent, all repository watcher-event matches and constructors use the expanded event shape, and no reachable failure was established from discarding the newly added value.

Important Files Changed

Filename Overview
Bitkit.xcodeproj/project.pbxproj Updates the exact package requirements for bitkit-core and ldk-node consistently with the resolved package graph.
Bitkit.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved Records the intended package versions and revisions for the two dependency upgrades.
Bitkit/Managers/HwWalletManager.swift Expands the watcher-event pattern to accept the new field while preserving existing snapshot processing.
Bitkit/ViewModels/Trezor/TrezorViewModel.swift Expands the watcher-event pattern while retaining the existing Trezor watcher state updates.
BitkitTests/HwWalletManagerFundingTests.swift Supplies the new address field in hardware-wallet funding watcher fixtures.
BitkitTests/HwWalletManagerTests.swift Supplies the new address field in hardware-wallet manager watcher fixtures.
BitkitTests/TrezorViewModelWatcherTests.swift Supplies the new address field in Trezor watcher fixtures.

Reviews (1): Last reviewed commit: "chore: bump bitkit-core 0.5.14 and ldk-n..." | Re-trigger Greptile

@ovitrif
ovitrif requested review from piotr-iohk and removed request for jvsena42 September 3, 2026 12:55
@ovitrif ovitrif changed the title chore: bump bitkit-core 0.5.14 and ldk-node 0.7.0-rc.66 chore: bump bitkit-core ldk-node to match android #1223 Sep 3, 2026
@ovitrif ovitrif changed the title chore: bump bitkit-core ldk-node to match android #1223 chore: bump bitkit-core ldk-node to match android Sep 3, 2026

@piotr-iohk piotr-iohk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ovitrif
ovitrif enabled auto-merge September 3, 2026 13:39
@ovitrif
ovitrif merged commit 9a5ebcc into master Sep 3, 2026
12 checks passed
@ovitrif
ovitrif deleted the chore/725-bump-core-ldk branch September 3, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: bump bitkit-core 0.5.14 and ldk-node 0.7.0-rc.66

2 participants