chore: bump bitkit-core ldk-node to match android - #726
Merged
Conversation
Greptile SummaryUpdates the exact Swift Package Manager pins for bitkit-core and ldk-node and adapts watcher-event handling to bitkit-core’s added address field.
Confidence Score: 5/5The PR appears safe to merge, with no concrete blocking or non-blocking defect identified in the changed code. The package pins and resolved revisions are internally consistent, all repository watcher-event matches and constructors use the expanded event shape, and no reachable failure was established from discarding the newly added value.
|
| Filename | Overview |
|---|---|
| Bitkit.xcodeproj/project.pbxproj | Updates the exact package requirements for bitkit-core and ldk-node consistently with the resolved package graph. |
| Bitkit.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved | Records the intended package versions and revisions for the two dependency upgrades. |
| Bitkit/Managers/HwWalletManager.swift | Expands the watcher-event pattern to accept the new field while preserving existing snapshot processing. |
| Bitkit/ViewModels/Trezor/TrezorViewModel.swift | Expands the watcher-event pattern while retaining the existing Trezor watcher state updates. |
| BitkitTests/HwWalletManagerFundingTests.swift | Supplies the new address field in hardware-wallet funding watcher fixtures. |
| BitkitTests/HwWalletManagerTests.swift | Supplies the new address field in hardware-wallet manager watcher fixtures. |
| BitkitTests/TrezorViewModelWatcherTests.swift | Supplies the new address field in Trezor watcher fixtures. |
Reviews (1): Last reviewed commit: "chore: bump bitkit-core 0.5.14 and ldk-n..." | Re-trigger Greptile
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #725
This PR aligns iOS SPM pins with Android synonymdev/bitkit-android#1223.
bitkit-corefrom0.5.3to0.5.14.ldk-nodefrom0.7.0-rc.63to0.7.0-rc.66.nextUnusedExternalAddressfield.After this merges, #693 should drop its
0.5.10pin and rebase onto0.5.14.Releases:
Preview
N/A — no user-visible changes.
QA Notes
Manual Tests
regression:Home → background the app → foreground Bitkit: Home remains responsive and the node stays usable.Automated Checks
nextUnusedExternalAddresstoWatcherEvent.transactionsChangedfixtures inHwWalletManagerTests.swift,HwWalletManagerFundingTests.swift, andTrezorViewModelWatcherTests.swift.HwWalletManagerTests,HwWalletManagerFundingTests,TrezorViewModelWatcherTests).2e5d3a3e263d2de044c3d5b9a9ddcc789c8cf651b6bbd240fb7fe407b5e9be84; ldk-node21ac13bfdc9fdd3099a688bd0053f8b14c74b5957943b2f09624886e65556a8e.Package.resolvedrevisions: bitkit-core890502f241e12305325cdd0f5e46b2752b9aedf4; ldk-node190a17d966cf5a685444cfa17c3a419c290bf26c.