Skip to content

fix: integrate 2.4.1 crash lib fixes - #1223

Merged
ovitrif merged 2 commits into
masterfrom
fix/1206-crash-lib-fixes
Sep 3, 2026
Merged

fix: integrate 2.4.1 crash lib fixes#1223
ovitrif merged 2 commits into
masterfrom
fix/1206-crash-lib-fixes

Conversation

@ovitrif

@ovitrif ovitrif commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Closes #1206
Fixes #982
Fixes #983

This PR consumes the published lib releases that fix the 2.4.1 production crashes.

Description

  • Bumps bitkit-core-android from 0.5.5 to 0.5.14 for the ARM32 UniFFI checksum crash.
  • Bumps ldk-node-android from 0.7.0-rc.63 to 0.7.0-rc.66 for the Tokio runtime self-drop SIGABRT.
  • Updates watcher test fixtures for the new nextUnusedExternalAddress field on WatcherEvent.TransactionsChanged.

Releases:

Preview

N/A — no user-visible changes.

QA Notes

Manual Tests

  • 1. Home → Receive: Savings and Spending tabs plus the receive QR render normally.
  • 2. regression: Home → background the app → foreground Bitkit: Home remains responsive and the node stays usable.
  • 3. Settings → Advanced → Dev Settings → LDK → Restart: Restart is disabled during stop/start, becomes enabled after completion, and Receive still works.

Automated Checks

  • Unit tests modified: add nextUnusedExternalAddress to WatcherEvent.TransactionsChanged fixtures in HwWalletRepoTest.kt and TrezorViewModelTest.kt.
  • Local verification: just compile, just test, just lint, and assembleDevDebug.
  • Packaged devDebug arm64 APK native build IDs match the published GitHub Packages AARs and their native-debug-symbols archives: libbitkitcore.so 27603ee02f5466cf9f23501c6e311ed46af25593, libldk_node.so 332c5f8bdae4c5a1eebe88fffaa8c03b8b0c38de.
  • Published AAR SHA-256: bitkit-core 51498ca5f3a4315c240898168581e6604257895446bbc45727e212662acdc962; ldk-node 6e1c88eddc8635ab85c4947ba19494ede39e41a5c969baf35f9eef55231d0e43.

@ovitrif ovitrif added this to the 2.5.0 milestone Sep 2, 2026
@ovitrif ovitrif self-assigned this Sep 2, 2026
@ovitrif
ovitrif requested a review from jvsena42 September 2, 2026 21:52
@greptile-apps

greptile-apps Bot commented Sep 2, 2026

Copy link
Copy Markdown

Greptile Summary

This PR upgrades bitkit-core and ldk-node to releases addressing ARM32 wallet and Lightning node shutdown crashes.

  • Bumps bitkit-core-android from 0.5.5 to 0.5.14.
  • Bumps ldk-node-android from 0.7.0-rc.63 to 0.7.0-rc.66.
  • Updates watcher-event test fixtures for the newly required nextUnusedExternalAddress field.
  • Adds a changelog entry describing both crash fixes.

Confidence Score: 5/5

The PR appears safe to merge, with no concrete blocking or non-blocking defects identified in the changed code.

The dependency upgrades are accompanied by the required watcher-event fixture updates, and the available evidence does not establish an API, ABI, packaging, persistence, or runtime regression.

Important Files Changed

Filename Overview
gradle/libs.versions.toml Updates the two native wallet and Lightning dependencies to the stated crash-fix releases; no concrete compatibility defect was identified.
app/src/test/java/to/bitkit/repositories/HwWalletRepoTest.kt Supplies the new required address field across hardware-wallet watcher-event fixtures.
app/src/test/java/to/bitkit/ui/screens/trezor/TrezorViewModelTest.kt Updates Trezor watcher-event fixtures for the new dependency-generated event shape.
changelog.d/next/1206.fixed.md Documents the Lightning shutdown and 32-bit wallet crash fixes.

Reviews (1): Last reviewed commit: "fix: integrate 2.4.1 crash lib fixes" | Re-trigger Greptile

@piotr-iohk

Copy link
Copy Markdown
Collaborator

LGTM

Do we want a counterpart PR on iOS for the same ldk-node / bitkit-core bumps?

@ovitrif

ovitrif commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator Author

LGTM

Do we want a counterpart PR on iOS for the same ldk-node / bitkit-core bumps?

Thanks sir, great concern raising 🙏🏻
Indeed, I'll handle this.

@ovitrif

ovitrif commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator Author

iOS counterpart is up: synonymdev/bitkit-ios#726

@ovitrif
ovitrif merged commit 7e7b807 into master Sep 3, 2026
18 checks passed
@ovitrif
ovitrif deleted the fix/1206-crash-lib-fixes branch September 3, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants