fix: integrate 2.4.1 crash lib fixes - #1223
Conversation
Greptile SummaryThis PR upgrades bitkit-core and ldk-node to releases addressing ARM32 wallet and Lightning node shutdown crashes.
Confidence Score: 5/5The PR appears safe to merge, with no concrete blocking or non-blocking defects identified in the changed code. The dependency upgrades are accompanied by the required watcher-event fixture updates, and the available evidence does not establish an API, ABI, packaging, persistence, or runtime regression.
|
| Filename | Overview |
|---|---|
| gradle/libs.versions.toml | Updates the two native wallet and Lightning dependencies to the stated crash-fix releases; no concrete compatibility defect was identified. |
| app/src/test/java/to/bitkit/repositories/HwWalletRepoTest.kt | Supplies the new required address field across hardware-wallet watcher-event fixtures. |
| app/src/test/java/to/bitkit/ui/screens/trezor/TrezorViewModelTest.kt | Updates Trezor watcher-event fixtures for the new dependency-generated event shape. |
| changelog.d/next/1206.fixed.md | Documents the Lightning shutdown and 32-bit wallet crash fixes. |
Reviews (1): Last reviewed commit: "fix: integrate 2.4.1 crash lib fixes" | Re-trigger Greptile
|
LGTM Do we want a counterpart PR on iOS for the same |
Thanks sir, great concern raising 🙏🏻 |
|
iOS counterpart is up: synonymdev/bitkit-ios#726 |
Closes #1206
Fixes #982
Fixes #983
This PR consumes the published lib releases that fix the
2.4.1production crashes.Description
bitkit-core-androidfrom0.5.5to0.5.14for the ARM32 UniFFI checksum crash.ldk-node-androidfrom0.7.0-rc.63to0.7.0-rc.66for the Tokio runtime self-drop SIGABRT.nextUnusedExternalAddressfield onWatcherEvent.TransactionsChanged.Releases:
Preview
N/A — no user-visible changes.
QA Notes
Manual Tests
regression:Home → background the app → foreground Bitkit: Home remains responsive and the node stays usable.Automated Checks
nextUnusedExternalAddresstoWatcherEvent.TransactionsChangedfixtures inHwWalletRepoTest.ktandTrezorViewModelTest.kt.just compile,just test,just lint, andassembleDevDebug.devDebugarm64 APK native build IDs match the published GitHub Packages AARs and theirnative-debug-symbolsarchives:libbitkitcore.so27603ee02f5466cf9f23501c6e311ed46af25593,libldk_node.so332c5f8bdae4c5a1eebe88fffaa8c03b8b0c38de.51498ca5f3a4315c240898168581e6604257895446bbc45727e212662acdc962; ldk-node6e1c88eddc8635ab85c4947ba19494ede39e41a5c969baf35f9eef55231d0e43.