Use bash {0} so a failing check does not abort the auto-merge eligibility run - #3409
Merged
Conversation
The previous fix was wrong. "shell: bash" expands to
"bash --noprofile --norc -e -o pipefail {0}", which still carries -e, so the run
kept stopping after 3 of 12 checks. Only the explicit "shell: bash {0}" form
drops it. Reproduced with the real scripts against #3366: -e stops at 3 checks
and exits 1, bash {0} runs all twelve and exits 0.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
pwizla
changed the title
pwizla
added
source: repo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix in #3408 was wrong and the run kept failing the same way.
shell: bashdoes not drop the -e flag: GitHub expands it tobash --noprofile --norc -e -o pipefail {0}, which the run log confirms. Only the explicitshell: bash {0}form runs without -e.A check exiting 1 is the normal output of this step — it means a criterion was violated — so -e killed the loop on the first one, after 3 of 12 checks and with no verdict.
Reproduced with the real scripts against #3366, which changes 34 lines and legitimately fails the 30-line criterion:
bash --noprofile --norc -e -o pipefailstops after 3 checks and exits 1, matching the observed run exactlybash {0}runs all of them, records the failure, finishes the loop and exits 0Applied to the six steps across both workflows whose scripts expect non-zero exit codes.
Should fix #3408