End the eligibility step on an explicit exit 0 - #3411
Merged
Conversation
All twelve checks ran and the verdict was recorded, but the step still failed. Its exit code is that of its last command, and the last one to run was the test on UNKNOWN: with no errored check that variable is empty, the test returns 1, and the step fails on a perfectly normal outcome. The step reports a verdict, it does not pass or fail on it — eligibility is carried by the output. Reproduced against #3366: same verdict either way, exit 1 before, exit 0 after. The other five steps across both workflows were not affected but get the same explicit ending, so no step's result depends on whichever command happens to be last.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
pr: chore
source: repo
pwizla
commented
Aug 26, 2026
pwizla
left a comment
pwizla
left a comment
Collaborator
Author
There was a problem hiding this comment.
Allright, let's merge & test 🤞
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All twelve checks ran, the summary table rendered, the verdict was recorded — and the step still failed. This is a different bug from the shell one fixed in #3409, and it was hidden behind it.
A step's exit code is that of its last command. The last one to run here is the test on
UNKNOWN, inside the block that writes the verdict. When no check errored — the normal case — that variable is empty, the test returns 1, and the step fails on a perfectly good outcome.The step reports a verdict; it does not pass or fail on it. Whether the PR is eligible is carried by the
eligibleoutput and read by the next step.Reproduced against #3366, which legitimately fails the 30-line criterion:
The other five steps across both workflows were not affected — they happen to end on an
echo— but they get the same explicit ending, so no step's result depends on whichever command is last.Should fix #3409