Stop the auto-merge eligibility run aborting on the first failing check - #3408
Merged
Conversation
GitHub runs a step as bash -e unless told otherwise, and set -uo pipefail does not undo it, so a check exiting 1 — a violated criterion, the normal output — killed the job. The first real run stopped after 3 of 12 checks with no verdict. shell: bash on the six steps whose scripts expect non-zero codes; the cron had the same latent bug on all three of its steps.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
pr: chore
source: repo
pwizla
changed the title
Collaborator
Author
|
let's go 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first manual run of the eligibility workflow failed. It stopped after 3 of 12 checks and reported the job as broken, when nothing was broken: #3366 simply changes 34 lines, over the 30-line limit.
GitHub runs a step as
bash -eunless told otherwise, andset -uo pipefaildoes not undo that. A check exiting 1 is this step's normal output — it means a criterion was violated — so-ekilled the loop at the first one.shell: bashon the six steps whose scripts expect non-zero exit codessed -Eso the PASS/FAIL prefix is actually stripped from the summary table (BSD sed does not read\|)Simulated against #3366: all twelve checks now run,
line-countfails, and the verdict is "Not eligible. Failed: line-count".Follows #3401