Skip to content

(closes #1312) fix scalar array functionality - #3520

Draft
mo-alistairp wants to merge 5 commits into
masterfrom
1312_fix_scalar_array_functionality_invoke_call
Draft

(closes #1312) fix scalar array functionality#3520
mo-alistairp wants to merge 5 commits into
masterfrom
1312_fix_scalar_array_functionality_invoke_call

Conversation

@mo-alistairp

@mo-alistairp mo-alistairp commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

The gh_scalar_array functionality is not working as intended (#1312). The generated kernel subroutine includes an array of the extents of the dimensions of the scalar array in the the list of arguments. This isn't being generated in the corresponding invoke call. As a result the mismatch in arguments causes build errors when gh_scalar_array is used.

This was likely because kern_call_invoke_arg_list.py was missed. This wasn't picked up by testing because the algorithm layer doesn't get compiled. As a way to verify that this functionality does work I'll also add an example using gh_scalar_array that gets compiled to ensure that it builds correctly. I'll probably also add a bit more documentation to aid users.

@mo-alistairp mo-alistairp self-assigned this Jul 31, 2026
@mo-alistairp mo-alistairp added bug in progress LFRic Issue relates to the LFRic domain LFRic PSyKAl-lite Issue related to removal of PSyKAl-lite code in LFRic labels Jul 31, 2026
@codecov

codecov Bot commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (2cd1054) to head (730eece).
⚠️ Report is 42 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #3520   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          397       397           
  Lines        55556     55590   +34     
=========================================
+ Hits         55556     55590   +34     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug in progress LFRic PSyKAl-lite Issue related to removal of PSyKAl-lite code in LFRic LFRic Issue relates to the LFRic domain

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant