#1312 fix scalar array functionality - #3519
Closed
mo-alistairp wants to merge 6 commits into
Closed
Conversation
mo-alistairp
added
bug
in progress
LFRic
mo-alistairp
changed the title
Collaborator
Author
|
This mistakenly has changes from another branch in it so I'm closing this PR and the correct changes are in #3520 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
gh_scalar_arrayfunctionality is not working as intended. The generated kernel subroutine includes an array of the extents of the dimensions of the scalar array in the the list of arguments. This isn't being generated in the corresponding invoke call. As a result the mismatch in arguments causes build errors whengh_scalar_arrayis used.This was likely because
kern_call_invoke_arg_list.pywas missed. This wasn't picked up by testing because the algorithm layer doesn't get compiled. As a way to verify that this functionality does work I'll also add an example usinggh_scalar_arraythat gets compiled to ensure that it builds correctly. I'll probably also add a bit more documentation to aid users.