http proxy: apply mission node affinity + tolerations to the proxy pod#413
Merged
sisuresh merged 2 commits intoJul 20, 2026
Merged
Conversation
The scalable nginx HTTP proxy Deployment's pod carried no affinity/tolerations, so it could only schedule on untainted capacity. On a busy cluster where the mission's node pool is tainted/dedicated (e.g. --require-node-labels=purpose:largetests --tolerate-node-taints=largetests), the proxy stayed Pending -> 'proxy not ready after 60 attempts' -> formation build failed. Mirror the core pods' placement (self.Affinity() + self.Tolerations()) so the proxy lands on the same pool it fronts. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Applies mission scheduling constraints to HTTP proxy pods so they can run on the same dedicated node pool as core pods.
Changes:
- Adds mission affinity and tolerations to the proxy pod specification.
- Documents the scheduling rationale.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Regression guard for the placement fix -- existing tests only exercise the core pod template, so they would not catch the proxy dropping affinity/tolerations again. Builds a config with require-node-labels + tolerate-node-taints and asserts ToHttpProxyDeployment().Spec.Template.Spec carries both. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
sisuresh
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ToHttpProxyDeployment), matching the core pods it fronts.Why
Fix
Testing
dotnet build -c Releaseclean;fantomas --check --recurse srcclean.Validation after merge
proxy not readytimeouts under concurrent load.🤖 Generated with Claude Code