http proxy: raise readiness budget for node cold-start + throttle poll log#414
Merged
Merged
Conversation
waitProxyReady allowed only 60 attempts x 2s (~120s). Now the proxy is pinned to the mission node pool (largetests/catchup), first-ready can take minutes while karpenter cold-provisions a node + the CNI assigns an IP, so the 120s budget expires before ready -> 'not ready after 60 attempts' -> formation build fails (seen across prod #1867/#1868). Raise to 300 attempts (~10 min); the mission timeout still bounds a genuinely stuck proxy. Also throttle the 'N ready' log to ~once/min instead of every 2s (was ~300 lines/run). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Extends HTTP proxy readiness handling for cold-started mission nodes while reducing poll-log noise.
Changes:
- Raises readiness budget to approximately 10 minutes.
- Logs readiness roughly once per minute and on success.
- Improves timeout diagnostics.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Cold-start on a dedicated node pool (karpenter provision + CNI IP assignment) can exceed 10 min under contention; raise the cap to 450 attempts (~15 min). Still finite so a genuinely stuck proxy fails with a clear error well inside the mission timeout. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Start at 1 so the loop runs exactly proxyReadyMaxAttempts (300) polls and the log reads attempt 1/300..300/300 instead of 0/300..300/300 (301 polls). Keep an initial log line via n = 1. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
sisuresh
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
waitProxyReadyfrom 60 attempts (~120s) to 300 (~10 min).Why
Testing
dotnet build -c Releaseclean;fantomas --check --recurse srcclean.Core/stellar-supercluster-testwithSUPERCLUSTER_PR=<this>+--require-node-labels=purpose:largetests --tolerate-node-taints=largetests, forcing a karpenter cold-start, confirming the proxy becomes ready within the new budget and the mission succeeds (see PR comment).Known limitations / follow-up (infra, not this PR)
aws-cni failed to assign an IP addresson largetests nodes is IP/ENI exhaustion when many pods land on a freshly-scaled node — a VPC-CNI / karpenter-nodeclass concern (prefix delegation / max-pods / instance ENI capacity). This PR tolerates the delay; the CNI capacity itself is worth a separate infra fix.Issue
🤖 Generated with Claude Code