Skip to content

refactor: use array/zeros in plot/components/svg/clip-path and plot/components/svg/marks #16369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Planeshifter wants to merge 2 commits into
base: develop
Choose a base branch
from
+9 −6
Draft

refactor: use array/zeros in plot/components/svg/clip-path and plot/components/svg/marks #16369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64fcc80
refactor: use `array/zeros` in `plot/components/svg/clip-path`
claude Oct 30, 2026
529c940
refactor: use `array/zeros` in `plot/components/svg/marks`
claude Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions lib/node_modules/@stdlib/plot/components/svg/clip-path/lib/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
var setReadOnly = require( '@stdlib/utils/define-read-only-property' );
var minstd = require( '@stdlib/random/base/minstd' );
var copy = require( '@stdlib/utils/copy' );
var zeros = require( '@stdlib/array/zeros' );
var defaults = require( './defaults.json' );
var validate = require( './validate.js' );
var setWidth = require( './props/width/set.js' );
Expand All @@ -49,12 +50,12 @@
/**
* Clipping path constructor.
*
* @constructor

Check failure on line 53 in lib/node_modules/@stdlib/plot/components/svg/clip-path/lib/main.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Invalid JSDoc tag (preference). Replace "constructor" JSDoc tag with "class"
* @param {Options} options - constructor options
* @param {PositiveNumber} [options.width=400] - width
* @param {PositiveNumber} [options.height=400] - height
* @param {string} [options.id] - clipping path id
* @param {boolean} [options.autoRender=true] - indicates whether to re-render on a change event
* @param {boolean} [options.autoRender=false] - indicates whether to re-render on a change event
* @throws {TypeError} must provide valid options
* @returns {ClipPath} clipping path instance
*
Expand Down Expand Up @@ -96,7 +97,7 @@
'configurable': false,
'enumerable': false,
'writable': true,
'value': opts.id || minstd().toString() // TODO: uuid

Check warning on line 100 in lib/node_modules/@stdlib/plot/components/svg/clip-path/lib/main.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unexpected 'todo' comment: 'TODO: uuid'
});
defineProperty( this, '_autoRender', {
'configurable': false,
Expand Down Expand Up @@ -131,9 +132,10 @@
var args;
var i;
debug( 'Received a render event. Re-emitting...' );
args = [ 'render' ];
args = zeros( arguments.length+1, 'generic' );
args[ 0 ] = 'render';
for ( i = 0; i < arguments.length; i++ ) {
args.push( arguments[ i ] );
args[ i+1 ] = arguments[ i ];
}
self.emit.apply( self, args );
}
Expand Down
7 changes: 4 additions & 3 deletions lib/node_modules/@stdlib/plot/components/svg/marks/lib/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ var logger = require( 'debug' );
var defineProperty = require( '@stdlib/utils/define-property' );
var setReadOnly = require( '@stdlib/utils/define-read-only-property' );
var copy = require( '@stdlib/utils/copy' );
var zeros = require( '@stdlib/array/zeros' );
var defaults = require( './defaults.json' );
var validate = require( './validate.js' );
var setClipPathId = require( './props/clip-path-id/set.js' );
Expand Down Expand Up @@ -111,10 +112,10 @@ function Marks( options ) {
var args;
var i;
debug( 'Received a render event. Re-emitting...' );
args = [];
args.push( 'render' );
args = zeros( arguments.length+1, 'generic' );
args[ 0 ] = 'render';
for ( i = 0; i < arguments.length; i++ ) {
args.push( arguments[ i ] );
args[ i+1 ] = arguments[ i ];
}
self.emit.apply( self, args );
}
Expand Down
Loading