Repository navigation
refactor: use array/zeros in plot/components/svg/clip-path and plot/components/svg/marks - #16369
Planeshifter wants to merge 2 commits into
Conversation
Build re-emitted render arguments using `@stdlib/array/zeros` (dependency and pattern present in 10/12 siblings, 83%), and correct the documented `autoRender` constructor default from `true` to `false` to match `lib/defaults.json` and the property's own `@default` (9/10 siblings documenting the option, 90%). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017wWD77X2B7byq3ZzHRrwGn
Build re-emitted render arguments using `@stdlib/array/zeros` instead of incremental `push` calls (dependency and pattern present in 10/12 siblings, 83%). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017wWD77X2B7byq3ZzHRrwGn
Coverage ReportNo coverage information available. |
|
The regression comes from 1dd0231 ( No fix PR exists yet. Proposed patch for the base JavaScript block in 'plugins': {
'n': pluginN,
'jsdoc': pluginJsdoc,
'@cspell': pluginCspell,
'stdlib': stdlibPlugin
},
+ 'settings': {
+ 'jsdoc': {
+ 'contexts': [
+ 'ArrowFunctionExpression',
+ 'ClassDeclaration',
+ 'ClassExpression',
+ 'FunctionDeclaration',
+ 'FunctionExpression'
+ ],
+ 'tagNamePreference': {
+ 'class': 'constructor'
+ }
+ }
+ },
'rules': rulesThe same Generated by Claude Code |
Description
This pull request:
plot/components/svg/clip-pathandplot/components/svg/marksin line with their siblings inplot/components/svg. Both now build re-emitted render arguments with@stdlib/array/zeros, and the wrongautoRenderdefault in theclip-pathconstructor JSDoc is fixed.Namespace summary
rectshas nopackage.jsonand is excluded).package.jsonkey sets, README sections, test/benchmark/example naming, public signature, return kind, validation prologue, error construction, JSDoc shape, and source dependencies.package.jsonkey sets (12/12),directorieskeysexample/lib(12/12), error construction viaformat(10/10 packages that throw), theoptionsplain-object check (10/10 packages that take options), the@stdlib/array/zerosdependency (10/12), thedefaults.json/autoRenderproperty files (10/12), and the documentedautoRender=falsedefault (9/10).options(7/12),validate.jsandevents/(7/12 each), and README,test/andbenchmark/(3/12 each).plot/components/svg/clip-pathonRenderbuilt its re-emitted arguments with[ 'render' ]pluspush. It now preallocates withzeros( arguments.length+1, 'generic' ), like 10 of 12 siblings (83%). The constructor JSDoc gave theautoRenderdefault astrue, which contradictslib/defaults.json, the property's own@default false, and 9 of 10 siblings that document the option (90%). It now saysfalse.plot/components/svg/marksonRenderbuilt its re-emitted arguments with an empty array and repeatedpushcalls. It now uses the samezeros( arguments.length+1, 'generic' )preallocation as 10 of 12 siblings (83%). The arguments passed toemitare the same as before.Related Issues
None.
Reference Packages
This pull request followed these packages:
plot/components/svg/graphplot/components/svg/titleonRenderargument construction and therequireplacement of@stdlib/array/zeros.Questions
No.
Other
Validation
lib/main.js,lib/index.jsandlib/validate.js, one agent per package.plot/ctor/plot/hist), and structural applicability. All three marked both corrections as confirmed drift.renderwith the same arguments (_render('a', 2)→render('a', 2)).Deliberately excluded
annotationsanddefslackdefaults.jsonand theautoRenderproperty. This is intentional: they are zero-argument components with no configurable state.symbolsdocumentsoptionsas required although the code treats it as optional. The public-signature feature has no majority, so this is left for a separate change.rugdeclares two@throws {TypeError}tags, unlike its siblings. This is not material on its own.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code, as part of an automated cross-package drift analysis using a majority vote.
@stdlib-js/reviewersGenerated by Claude Code